fixing filtering of lists#311
Open
orangecoding wants to merge 1 commit into
Open
Conversation
|
I have tested fixing-listing-filtering branch, and it has generated a new bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem...
In storeListings, each listing row is saved with two distinct identifiers:
After _save, the listing objects in memory still carry the provider ID in listing.id. The three post-save filter methods (_filterBySimilarListings, _filterBySpecs, _filterByArea) all collected those values and passed them to
deleteListingsById, which ran:
UPDATE listings SET manually_deleted = 1 WHERE id IN (?)
The id column holds nanoids, so the provider IDs never matched, the soft-delete was a no-op and filtered listings remained visible.