Fixed clear() function not working + added test - #4
Closed
wole-kolawole wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
|
closing... out of date |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the reliability of the cache clearing mechanism and adds a dedicated test to ensure correct behavior when the cache file is modified by another process during a pending clear operation. The main theme is to prevent stale or unexpected data from being reloaded after a clear, even if the file is changed externally before the clear operation is flushed.
Bug Fixes & Reliability Improvements:
load()function inindex.jsto check for a pending clear operation (_clearPending) before reloading data from disk, preventing the in-memory store from being repopulated with stale or external data during a clear.Testing Enhancements:
tests/clear.spec.jsto simulate an external file change during a pending clear, verifying that all keys remain cleared and no external data is loaded after a clear operation.