image-installer: apply kernel.append to installed system via kickstart (HMS-11181) - #2590
image-installer: apply kernel.append to installed system via kickstart (HMS-11181)#2590swthakur wants to merge 1 commit into
Conversation
customizations.kernel.append was being applied to the installer ISO boot cmdline instead of the installed system. Route those options through kickstart bootloader --append for image-installer, and keep them off the ISO GRUB cmdline.
supakeen
left a comment
supakeen
left a comment
There was a problem hiding this comment.
So as I said elsewhere this needs some discussion. First: the implementation code-wise is mostly fine.
However this change would break our backwards compatibility guarantees that we give. I agree that it might make more sense that kernel.append applies to the to-be installed system and that perhaps we should have (if we don't already) an installer.kernel.append that only affects the installer.
But because the current behavior affects the installer users might be relying on it. Thus taking it away is a problem as it would break other users if we don't offer an alternative way of doing it, document it as a breaking change, and make sure people know about it.
Personally I'd go with:
kernel.appendaffects the installed system.installer.kernel.appendaffects the installer.
Both in a single implementation, but I don't know how we handle the breaking of previous workflows correctly.
cc @achilleas-k / @ondrejbudai for your input on this 🙂
supakeen
changed the title
|
Thanks — agreed on avoiding a silent breaking change; I previously raised a broader installer-customization RFE (RHEL-191772). Your proposal fits as a focused first step:
|
2 participants
Summary
customizations.kernel.appendfor classicimage-installerISOs.bootloader --append.Why
Blueprint kernel append is intended for the installed system bootloader.
For
image-installer, the OS payload is a liveimg tar (no disk partition table), soorg.osbuild.kernel-cmdlineis not emitted for the payload. Kickstart is the correct path.Changes
pkg/distro/generic/images.go: copy kernel options toKickstart.KernelOptionsAppend, clear them fromInstallerCustomizations.KernelOptionsAppend.pkg/manifest/anaconda_installer_iso_tree.go: emitbootloader --appendinmakeKickstartStages.Related to #2175 (previous attempt, closed unmerged).