image-builder: reuse progress bars for upload - #2592
Open
croissanne wants to merge 3 commits into
Open
Conversation
croissanne
force-pushed
the
progress-upload
branch
5 times, most recently
from
August 12, 2026 15:46
f73a84c to
084b213
Compare
croissanne
marked this pull request as ready for review
August 13, 2026 10:31
achilleas-k
approved these changes
Aug 13, 2026
The terminal and file progress bars keep track of levels of progress. When stopping (and restarting) the progress bar, these levels need to be cleared in order to accurately show the progress of the next bigger step (which is assumed to be separate from the first). For instance, build and upload.
This reader keeps a reference to a progress bar, updating it as bytes are read from the underlying `io.Reader`. This is useful to use our existing progress bars for uploads.
Using the proxy reader and the ability to restart progress bars, the progress bars can be used for uploads as well.
supakeen
force-pushed
the
progress-upload
branch
from
August 17, 2026 03:37
084b213 to
934d238
Compare
croissanne
marked this pull request as draft
August 17, 2026 08:35
Member
Author
|
Alright, I changed it a bit to make the bar identical to the upload bar (which is just the default config with bytes true) old: 
new: 
|
croissanne
marked this pull request as ready for review
August 17, 2026 10:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the proxy reader and the ability to restart progress bars, the
progress bars can be used for uploads as well.