Skip to content

fedora: drop explicit anaconda-widgets - #2597

Open
supakeen wants to merge 1 commit into
osbuild:mainfrom
supakeen:dont-require-anaconda-widgets
Open

fedora: drop explicit anaconda-widgets#2597
supakeen wants to merge 1 commit into
osbuild:mainfrom
supakeen:dont-require-anaconda-widgets

Conversation

@supakeen

Copy link
Copy Markdown
Member

We explicitly require anaconda-widgets but anaconda uses rich requires to select between anaconda-gui and anaconda-webui.

anaconda-gui requires anaconda-widgets so the solver sees anaconda-widgets in the transaction and finds it can solve more dependencies by selecting -gui instead of -webui.

Drop the explicit listing of anaconda-widgets to ensure rich dependency resolution works.

I've applied this to all versions instead of version gating it; it's theoretically a bug to have this in the list and shouldn't affect the actual output artifacts.

We explicitly require `anaconda-widgets` but `anaconda` uses rich
requires to select between `anaconda-gui` and `anaconda-webui`.

`anaconda-gui` requires `anaconda-widgets` so the solver sees
`anaconda-widgets` in the transaction and finds it can solve more
dependencies by selecting `-gui` instead of `-webui`.

Drop the explicit listing of `anaconda-widgets` to ensure rich
dependency resolution works.

I've applied this to all versions instead of version gating it; it's
theoretically a bug to have this in the list and shouldn't affect the
actual output artifacts.

Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
@supakeen
supakeen requested a review from a team as a code owner August 14, 2026 08:36
KKoukiou added a commit to KKoukiou/anaconda that referenced this pull request Aug 14, 2026
The previous `(anaconda-webui or anaconda-gui)` fallback was
non-deterministic - RPM's boolean `or` does not guarantee preference
order.

Image Builder was pulling anaconda-widgets (see
osbuild/image-builder#2597), which is a
dependency of anaconda-gui, resulting in DNF resolving the `or` in
favor of anaconda-gui since it was partially satisfied.

Replace the two Requires lines with a single `if...else` rich
dependency: install anaconda-gui on Server and Everything (basic),
anaconda-webui on everything else.
KKoukiou added a commit to rhinstaller/anaconda that referenced this pull request Aug 14, 2026
The previous `(anaconda-webui or anaconda-gui)` fallback was
non-deterministic - RPM's boolean `or` does not guarantee preference
order.

Image Builder was pulling anaconda-widgets (see
osbuild/image-builder#2597), which is a
dependency of anaconda-gui, resulting in DNF resolving the `or` in
favor of anaconda-gui since it was partially satisfied.

Replace the two Requires lines with a single `if...else` rich
dependency: install anaconda-gui on Server and Everything (basic),
anaconda-webui on everything else.

@brlane-rht brlane-rht left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants