Skip to content

Make Codex cleanup deadline deterministic (#101) - #191

Closed
Niko4417 wants to merge 5 commits into
epic/98-codex-tracerfrom
codex/101-cleanup-determinism-v8
Closed

Make Codex cleanup deadline deterministic (#101)#191
Niko4417 wants to merge 5 commits into
epic/98-codex-tracerfrom
codex/101-cleanup-determinism-v8

Conversation

@Niko4417

Copy link
Copy Markdown
Collaborator

Scope

Product and architecture alignment

  • The implemented contract version and fingerprint match the automated readiness record; no semantic planning change was absorbed during implementation.
  • The change follows the Decision Addendum, CONTEXT.md, accepted ADRs, and the issue Quality Plan.
  • Existing Keiko material was used only after a recorded Reuse Assessment, or the issue records why Existing Keiko evidence is not applicable.
  • This greenfield change creates no mandatory build-time or runtime dependency on Existing Keiko.
  • Product authority, policy, evidence, and privileged effects remain in their owning Native layer.
  • Any durable architecture change is recorded in an ADR.

Acceptance criteria and evidence

Acceptance criterion Evidence Exact head or artifact Result
AC1 Anchored 300 ms phases; strict post-deadline refusal; mandatory direct-child reap; exact ESRCH/ECHILD absence; unavailable observations retain ownership 222fe918295ac52d13138e5570832cdf27efeabe Local passed; remote pending
AC2 Authoritative PR #190 named failure; deterministic deadline seams; three host suites 171/171; three exact coverage wrappers 222fe918295ac52d13138e5570832cdf27efeabe Local passed; macOS 14/26 pending
AC3 Separate TERM-resistant parent/reap proof retained; timeout fixture stabilized to one non-churning process; descendant-first order and turn policy unchanged 222fe918295ac52d13138e5570832cdf27efeabe Passed
AC4 One authorized runtime file; no deadline/gate/assertion/dependency/#104/#49 change; identity, absence, ownership, and recovery audit findings zero 222fe918295ac52d13138e5570832cdf27efeabe Passed
AC5 Full quality, audit, package/platform/security/signing/test, standard macOS acceptance 222fe918295ac52d13138e5570832cdf27efeabe Local passed; final integrated canonical pending

Acceptance journey evidence

  • Applicability: Not applicable — this is a non-user-facing runtime containment defect; Epic #98 owns the visible tracer journey and final canonical evidence.

  • Automated checks exercise user-visible outcomes rather than incidental implementation details.

  • Required failure, recovery, accessibility, visual, and platform observations are settled.

Quality Plan settlement

  • Applicable positive, negative, boundary, failure, cancellation, and recovery behavior is covered.
  • The actually wired production composition was tested where this change crosses layers.
  • Applicable security, accessibility, performance, resource, visual, and platform evidence is attached or linked.
  • Excluded quality areas retain the rationale accepted in the issue.
  • Secrets, credentials, raw customer content, private endpoints, and PII are absent from source, tests, logs, evidence, artifacts, issues, and this pull request.

Verification

  • npm ci --ignore-scripts
  • npm run quality
  • npm audit --audit-level=high
  • Every declared native target-specific gate passed on its authoritative platform.
  • I reviewed the complete diff against requirements, contracts, trust boundaries, and failure modes.

Additional affected checks and concise results:

Exact head: 222fe918295ac52d13138e5570832cdf27efeabe
Failure-first: PR #190 run 31342226233, macOS 26 native:coverage, named cleanup test 160/161
Focused deadline/cleanup/recovery tests: passed
Complete host suite: 171/171 x3
npm run native:coverage: 3/3 sequential passes
Native branch coverage: 85.0877%; runtime.rs 85.3365%
npm run quality: passed; host 171/171
npm audit --audit-level=high: 0 vulnerabilities
npm run acceptance:macos: passed
Independent exact-head audit: findings 0
Signatures: Good ED25519; private repository email
Residual test/process groups: 0

Independent audit and findings

Confirmed finding Evidence Disposition Settlement evidence or follow-up
Process-group inspection treated all signal-0 errors as absence Independent audit Resolved Exact ESRCH alone proves absence; other errors fail closed
Retained recovery could retire after group absence without reaping the direct child Independent audit Resolved Mandatory reap plus exact ECHILD/post-reap proof
Timeout fixture continuously churned sleep descendants under coverage First post-change 170/171 failure and fixture inspection Resolved Stable one-process timeout fixture; host 171/171 x3 and coverage green
  • Findings are evidence-cited; speculative observations are advisory rather than blockers.
  • Every confirmed finding is resolved, explicitly accepted by an authorized human, or linked to a scoped follow-up that does not invalidate current acceptance.
  • Verification and audit were repeated after the latest implementation or audit fix.

Integrated epic acceptance

Delivery

  • Target path: child issue -> epic branch
  • The target branch matches the delivery path accepted in the issue; no direct push, force push, gate bypass, finding dismissal, or authority widening occurred.
  • Commits are signed and every required check is bound to the exact current head and expected producer.
  • Advisory tools are not treated as required merge authority under the current quality-gate policy.
  • Documentation, ADRs, contracts, known limitations, and follow-ups are current.
  • A draft pull request was not promoted to Ready for Human Review before every required Acceptance Journey result and exact-head gate was complete.

For a child-issue pull request targeting its designated epic branch:

  • The accepted issue authorizes this epic-branch target.
  • Acceptance and audit evidence is complete, every applicable exact-head gate is green, and no blocking finding or review conversation remains.

Residual risks and follow-ups

Closes #101

@Niko4417

Copy link
Copy Markdown
Collaborator Author

@codex review\n\nReview exact head 222fe918295ac52d13138e5570832cdf27efeabe. Focus on fixed 300 ms deadline accounting, strict post-deadline behavior, direct-child reap, exact PID/process-group absence classification, retained ownership and recovery, unavailable inspection, PID reuse, preservation of turn cleanup, fixture hermeticity, and strict #101 v7 scope. All local gates and independent audit are green; authoritative macOS CI is running.

@Niko4417

Copy link
Copy Markdown
Collaborator Author

Superseded by readiness-accepted atomic bridge #195. The complete audited #101 aggregate through b2a6de735489024b2cf5e0fd961304965b2ceecb remains immutable input evidence; this PR is closed without merge or retry, and standalone acceptance is not claimed as passed.

@Niko4417 Niko4417 closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant