ci: wasm: fetch the onnxruntime prebuilt alongside the SDK - #2175
Closed
jcelerier wants to merge 1 commit into
Closed
ci: wasm: fetch the onnxruntime prebuilt alongside the SDK#2175jcelerier wants to merge 1 commit into
jcelerier wants to merge 1 commit into
Conversation
score-addon-onnx can no longer download an onnxruntime for wasm: the public prebuilts are legacy-EH and do not link against -fwasm-exceptions /-sJSPI. It now expects $OSSIA_SDK/onnxruntime, which ossia/sdk builds with the same emscripten as the rest of the SDK and publishes as its own asset of the same release.
Member
Author
|
Wrong layer. Fetching the onnxruntime prebuilt is a plugin concern: score-addon-onnx and sherpa-plugins should each pull it, pinned to the same version, and whichever declares it first wins. score itself should not know about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
score-addon-onnx can no longer download an onnxruntime for wasm: the public
prebuilts are legacy-EH and leave
__resumeExceptionundefined against-fwasm-exceptions/-sJSPI. It now takes the archive from$OSSIA_SDK/onnxruntime, which ossia/sdk builds with the same emscripten asthe rest of the SDK.
That artifact is a separate asset of the same release rather than part of
sdk-wasm.tar.xz, so it needs its own download. Its archive is rooted atlib/andinclude/, so unlike the SDK tarball it takes no--strip-components.The tag moves to
sdk38so both assets come from one SDK build. Otherplatforms keep their existing pins.
Depends on ossia/sdk#24 and ossia/score-addon-onnx#45. Do not merge before a
release exists with both assets, or the wasm build will fail at configure with
the message the addon change adds.