Fix NoMethodError when validating a child event with no start date - #4213
Open
SAY-5 wants to merge 1 commit into
Open
Fix NoMethodError when validating a child event with no start date#4213SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Fixes #4189.
When a child event is submitted without a start date,
in_parent_dates?runsfrom_day < parent.from_dayand raisesNoMethodError: undefined method '<' for nilinstead of returning a validation error.from_dayalready has apresence: truevalidation, so the missing date is reported anyway once this comparison stops crashing. This guardsin_parent_dates?to skip the range check whenfrom_dayorto_dayis nil, matching how the SQL-basedno_child_before?/no_child_after?siblings already tolerate nil.Added a model test for a child event with no start date. It needs the full Rails/Postgres test harness to run, which I could not stand up locally, but it mirrors the existing
event_test.rbcases.Niveau d'incidence