Skip to content

Drop aria-labels that duplicate visible text in first-run setup #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charneykaye merged 1 commit into from
Aug 22, 2026
Merged

Drop aria-labels that duplicate visible text in first-run setup #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/web/src/setup/steps/InstallingStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,9 @@ export function InstallingStep({ flow, mode }: InstallingStepProps) {
conversations different and preview the actual scenarios the player is
minutes away from, so the first conversation is the real model. */}
{mode === 'wizard' && (
// Plain div, not a named region: the eyebrow and heading below are the
// section's own visible text, so a region label would repeat them.
<div
role="region"
aria-label={t('setup.installing.whileHeading')}
style={{
marginTop: '1.75rem',
padding: '1.25rem 1.5rem',
Expand Down Expand Up @@ -250,8 +250,8 @@ export function InstallingStep({ flow, mode }: InstallingStepProps) {
<h3 style={{ margin: '0 0 0.6rem', fontSize: '0.8rem', color: '#a5b4fc', textTransform: 'uppercase', letterSpacing: '0.06em', fontWeight: 600 }}>
{t('setup.installing.missionsHeading')}
</h3>
{/* The visible h3 above labels this list; no aria-label needed. */}
<ul
aria-label={t('setup.installing.missionsHeading')}
style={{ listStyle: 'none', margin: 0, padding: 0, display: 'flex', flexDirection: 'column', gap: '0.6rem' }}
>
{previews.map((s) => (
Expand Down
5 changes: 3 additions & 2 deletions apps/web/src/setup/steps/WelcomeStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,11 @@ export function WelcomeStep({ flow }: { flow: UseSetupFlowReturn }) {
{t('setup.welcome.subheadline')}
</p>

{/* The promise — why this is not a chatbot (issue #473) */}
{/* The promise — why this is not a chatbot (issue #473). No aria-label:
the heading below is the note's visible content, so labelling the
note with the same text would double-announce it to screen readers. */}
<div
role="note"
aria-label={t('setup.welcome.promise.heading')}
style={{
marginBottom: '1.5rem', padding: '1rem 1.25rem',
background: 'rgba(255,255,255,0.03)', border: '1px solid rgba(255,255,255,0.1)',
Expand Down