feat(api): allow overriding http-security-headers in middyfy#31
Merged
Conversation
Adds securityHeadersOptions to middyfy() so consumers can configure @middy/http-security-headers per-handler. Includes an embeddable resource preset that relaxes CORP/COEP/COOP for handlers serving images or other resources embedded cross-origin. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
There was a problem hiding this comment.
Pull request overview
This PR adds an opt-in way to override @middy/http-security-headers options via the shared middyfy() wrapper, enabling specific handlers (e.g., media/resources) to be embeddable cross-origin without changing the default security posture for all endpoints.
Changes:
- Add
securityHeadersOptionstomiddyfy()props and pass it through tohttpSecurityHeaders(...). - Introduce
embeddableResourceSecurityHeaderspreset for cross-origin embeddable resources. - Re-export the new preset/type from the middleware barrel index.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/api/src/lib/middleware/middyfy.ts | Adds a securityHeadersOptions prop and forwards it to @middy/http-security-headers. |
| packages/api/src/lib/middleware/index.ts | Re-exports the new security-headers preset/type from the middleware entrypoint. |
| packages/api/src/lib/middleware/embeddableResourceSecurityHeaders.ts | Adds a documented preset (embeddableResourceSecurityHeaders) plus a helper options type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgoerdes
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.