fix reverting locale in single_include#119
Merged
Merged
Conversation
This complements pull-request p-ranav#110
Owner
|
Yeah please include the changes from #110 and I can merge it all in one-go here. Thanks! |
Contributor
Author
|
@p-ranav Done. |
|
@p-ranav is there anything I can do to help you merge this change? It's a really important bug fix for me! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the author of pull-request #110 didn't change the single include file. This PR complements it.
I verified that this fixes an issue that I encountered in my tool which uses tabulate. The tool is supposed to use "C" locale, but after printing a 'tabulate' table, it gets changed to the environment locale (because format's default locale is "") and then subsequent writes to new files use the environment locale instead of "C".
@p-ranav - if you want I can include the changes from #110 here as well - let me know.