Reuse cached full dyld cache for lookups - #33
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes dyld cache lookups by reusing an already-associated FullDyldCache when available, avoiding redundant cache traversals/reopens while keeping main-cache-first behavior consistent across main/subcaches.
Changes:
- Routes
MachOFiledyld-cache address resolution throughcache._cachedFullCachewhen present. - Adds
FullDyldCache.locateValuehelpers to resolve values across main cache + subcaches with optional exclusion. - Updates
DyldCache.locateValueto delegate to the cachedFullDyldCache(excluding the already-checked cache) when available.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Sources/MachOObjCSection/Extension/MachOFile+.swift | Reuses cached full-cache state for address→cache/fileOffset lookups and Objective-C selector base offset resolution. |
| Sources/MachOObjCSection/Extension/FullDyldCache+.swift | Introduces hierarchy-wide locateValue helpers with exclusion support. |
| Sources/MachOObjCSection/Extension/DyldCache+.swift | Delegates locateValue to an associated FullDyldCache to avoid re-checking caches. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DyldCache.locateValuethrough an already-associatedFullDyldCacheFullDyldCache.locateValuehelpers that search the main cache and its subcachesMachOFileWhy
Lookup paths previously traversed or reopened individual dyld cache files even when a complete
FullDyldCachewas already available. This change reuses the associated full-cache view, keeps main/subcache lookup behavior consistent, and avoids evaluating the same subcache twice during delegated resolution.Impact
Mach-O Objective-C metadata and address resolution can reuse existing full-cache state instead of reconstructing cache access paths, while preserving fallback behavior for standalone
DyldCacheinstances.Validation
swift buildswift test --filter MachOObjCSectionTests.testCategories2InCacheFile