Fix relative list regressions - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
symbol(...)compatibility extension now provided by MachOKit_UTCoreTypeRoot cause
The cache lookup introduced with the relative-list implementation conflated the cache containing the resolved Mach-O with the cache backing the list data. Separately, the image-index lookup selected only the first matching relative-list entry, while the pre-0.8 implementation combined all matching lists.
This caused Objective-C metadata to be partially omitted when a class had multiple relative lists or when the Mach-O and list data were located in different dyld cache files. MachOKit 0.52.1 also retained a related omission bug, so this package now requires 0.52.2.
Impact
Callers of
classInfo(in:)can once again obtain all matching relative methods, properties, and protocols instead of silently losing later lists.Validation
swift test: 26 tests, 0 failuresgit diff --check