Skip to content

feat!(WIP): migrate to just #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mfocko wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat!(WIP): migrate to just #666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ Five agents process tasks through Redis queues (see [README-agents.md](README-ag
1. **Edit agent code** in `ymir/agents/`
2. **Run dry-run test**:
```bash
make run-triage-agent-standalone JIRA_ISSUE=RHEL-12345 DRY_RUN=true MOCK_JIRA=true
just run-triage-agent RHEL-12345 DRY_RUN=true MOCK_JIRA=true
```
3. **Use mock Jira** (from `git@gitlab.cee.redhat.com:jotnar-project/testing-jiras.git`) for consistent test data
4. **Verify with full pipeline**:
```bash
make start DRY_RUN=true
make trigger-pipeline JIRA_ISSUE=RHEL-12345
just start DRY_RUN=true
just trigger-pipeline RHEL-12345
Comment on lines +33 to +34

@gemini-code-assist gemini-code-assist Bot Jul 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The commands inside the code block are missing indentation, which breaks the markdown list formatting.

Suggested change
just start DRY_RUN=true
just trigger-pipeline RHEL-12345
just start DRY_RUN=true\n just trigger-pipeline RHEL-12345

```
5. **Check agent logs**: Review output to ensure logic works as expected

Expand All @@ -43,7 +43,7 @@ Tools in `ymir/tools/privileged/` require special care:
2. **Test against actual repos** (dist-git clones) when possible
3. **Run full test suite before submitting**:
```bash
make check-in-container
just check-in-container
```
4. **Key file**: `ymir/tools/privileged/distgit.py` — handles clone/checkout for dist-git

Expand All @@ -53,24 +53,24 @@ Tools in `ymir/tools/privileged/` require special care:
### Unit Tests
```bash
# All tests in containers
make check-in-container
just check-in-container

# Specific components in containers
make check-agents-in-container
make check-privileged-tools-in-container
make check-unprivileged-tools-in-container
just check-agents-in-container
just check-privileged-tools-in-container
just check-unprivileged-tools-in-container
```

> **Rootless podman**: if the build step fails with "cannot re-exec process to join the existing user namespace", skip the image build and run the container directly with `--privileged`:
> ```bash
> podman run --rm --privileged -v $(pwd):/src:z beeai-tests make -f Makefile.tests check-privileged-tools
> podman run --rm --privileged -v $(pwd):/src:z beeai-tests just check-privileged-tools
> ```

### Manual Testing with Real Data Flow
1. Start full pipeline: `make start DRY_RUN=true`
1. Start full pipeline: `just start DRY_RUN=true`
2. Monitor traces: http://localhost:6006/ (Phoenix)
3. Monitor queues: http://localhost:8081/ (Redis)
4. Trigger: `make trigger-pipeline JIRA_ISSUE=RHEL-12345`
4. Trigger: `just trigger-pipeline RHEL-12345`
5. Review agent logs to see decision-making

## Common Issues & Gotchas
Expand Down Expand Up @@ -114,7 +114,7 @@ For detailed deployment info: see [openshift/README.md](openshift/README.md)
## Code Changes Checklist

- [ ] Write tests first (especially for tools/git operations)
- [ ] Run `make check-in-container` — all tests pass
- [ ] Run `just check-in-container` — all tests pass
- [ ] Test with `DRY_RUN=true` — don't touch real Jira/git
- [ ] Use rebase merge (see [CONTRIBUTING.md](CONTRIBUTING.md))
- [ ] Don't modify `.env`, `.secrets/`, keytab files in PRs
Expand All @@ -127,10 +127,10 @@ For detailed deployment info: see [openshift/README.md](openshift/README.md)
uv sync --extra test

# Run all tests in containers
make check-in-container
just check-in-container

# Test single agent
make run-triage-agent-standalone JIRA_ISSUE=RHEL-12345 DRY_RUN=true MOCK_JIRA=true
just run-triage-agent RHEL-12345 DRY_RUN=true MOCK_JIRA=true

# Run full pipeline with monitoring
make start DRY_RUN=true
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ only need to clone it once; the tests run entirely offline against the local cop
### Running

```bash
make run-triage-agent-e2e-tests
make run-backport-agent-e2e-tests
just run-triage-agent-e2e-tests
just run-backport-agent-e2e-tests
```

Both targets hardcode `MOCK_JIRA=true` and `DRY_RUN=true`. The mock Jira files are writable,
Expand Down
Loading