Skip to content

Add generic config handling and move the generic code - #36

Merged
LecrisUT merged 10 commits into
packit:mainfrom
LecrisUT:feat/config
Aug 18, 2026
Merged

Add generic config handling and move the generic code#36
LecrisUT merged 10 commits into
packit:mainfrom
LecrisUT:feat/config

Conversation

@LecrisUT

@LecrisUT LecrisUT commented May 14, 2026

Copy link
Copy Markdown
Collaborator
  • Added a handling for fedora-ci.yaml, etc.
  • Broke the symlinks between the other tests to the dist-git-prepare.py
  • Moved much of the common code to an utils package

@LecrisUT

Copy link
Copy Markdown
Collaborator Author

CC @FrostyX, see 893f3e9 mainly

@LecrisUT

LecrisUT commented May 14, 2026

Copy link
Copy Markdown
Collaborator Author

So here is a test run: https://artifacts.dev.testing-farm.io/7124c1ac-f6c5-41a8-a7a2-accc4cda6fe3/

  • rpmlint works fine rpmlint.toml is picked up
  • fedora-review could not run because testing-farm did not allow it, raising a followup issue
    • ran it locally and it seemed fine
      INFO: Processing local files: python3.15
      INFO: Getting .spec and .srpm Urls from : Local files in /var/tmp/tmt/run-026/plans/fedora-review/data
      INFO:   --> SRPM url: file:///var/tmp/tmt/run-026/plans/fedora-review/data/python3.15-3.15.0~b1-1.eln156.src.rpm
      INFO:   --> Spec url: file:///var/tmp/tmt/run-026/plans/fedora-review/data/python3.15.spec
      INFO: Using review directory: /var/tmp/tmt/run-026/plans/fedora-review/data/review-python3.15
      
      (failed after that for more issues to investigate 🙃)
  • license-validate the file was picked right but the test failed for some undetermined reason (Edit: it was because it ran on eln)

Edit: tried again against tmt: https://artifacts.dev.testing-farm.io/8f38640e-a69d-4863-ade0-28b09df62769/ and still good

@LecrisUT LecrisUT mentioned this pull request May 18, 2026
@LecrisUT LecrisUT linked an issue May 18, 2026 that may be closed by this pull request

@FrostyX FrostyX left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR @LecrisUT,
I really appreciate the feature.

I don't like / I am confused about some implementation details and I think all of them stem from the not sharing one distgit-prepare.py for all tests but rather duplicating it for every test. IMHO it would make things much easier if we moved it to utils. What do you think about that?

Comment thread utils/__init__.py
Comment thread utils/__init__.py
Comment thread tests/fedora-review/distgit-prepare.py
Comment thread tests/rpmlint/distgit-prepare.py

@mfocko mfocko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM… is there anything blocking this?

Comment thread tests/rpmlint/distgit-prepare.py Outdated
Comment thread tests/rpmlint/distgit-prepare.py Outdated
Comment thread tests/rpmlint/distgit-prepare.py Outdated
Comment thread tests/rpmlint/distgit-prepare.py Outdated
Comment thread tests/rpmlint/utils
@LecrisUT

LecrisUT commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator Author

@FrostyX can you give it one more look over and if all good we can go with this base and iterate more as we need.

Resolved in internal chat, all fine to go ahead and iterate more from this.

@LecrisUT
LecrisUT merged commit 91d907a into packit:main Aug 18, 2026
1 check passed
@LecrisUT
LecrisUT deleted the feat/config branch August 18, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a common dist-git configuration file for rpmlint/rpminspect/etc.

3 participants