Add generic config handling and move the generic code - #36
Conversation
|
So here is a test run: https://artifacts.dev.testing-farm.io/7124c1ac-f6c5-41a8-a7a2-accc4cda6fe3/
Edit: tried again against tmt: https://artifacts.dev.testing-farm.io/8f38640e-a69d-4863-ade0-28b09df62769/ and still good |
FrostyX
left a comment
There was a problem hiding this comment.
Thank you very much for the PR @LecrisUT,
I really appreciate the feature.
I don't like / I am confused about some implementation details and I think all of them stem from the not sharing one distgit-prepare.py for all tests but rather duplicating it for every test. IMHO it would make things much easier if we moved it to utils. What do you think about that?
mfocko
left a comment
There was a problem hiding this comment.
LGTM… is there anything blocking this?
|
@FrostyX can you give it one more look over and if all good we can go with this base and iterate more as we need. Resolved in internal chat, all fine to go ahead and iterate more from this. |
fedora-ci.yaml, etc.