Skip to content

fedora-review: Allow to be run in testing-farm multihost pipeline - #40

Open
LecrisUT wants to merge 1 commit into
packit:mainfrom
LecrisUT:fix/fedora-review-multihost
Open

fedora-review: Allow to be run in testing-farm multihost pipeline#40
LecrisUT wants to merge 1 commit into
packit:mainfrom
LecrisUT:fix/fedora-review-multihost

Conversation

@LecrisUT

Copy link
Copy Markdown
Collaborator

In principle this is a testing-farm bug that it should try to translate those, but I guess it doesn't hurt to be explicit here for now.

how: virtual
image: fedora
adjust+:
- when: initiator == packit, fedora-ci

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do the comma here?

@LecrisUT LecrisUT Aug 18, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, nasty feature to wrap my head when trying to change the fmf context code. It goes both ways even, and god I hope people don't use it the other way around.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbf it would’ve probably been more intuitive if it followed the same convention as ansible (either one expression or list joined via AND)

@LecrisUT

Copy link
Copy Markdown
Collaborator Author

Test executions for both cases:

As far as this change is concerned it does give a VM/artemis for both of them (can see in the run workdir -> provision -> steps.yaml)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants