feat: show each queue's feed address on the Postqueues screen - #3
Merged
Conversation
Under Tools > Postqueues, where Postqueue lists the queues, a Feed column now gives each queue's address, so it can be read and copied where the queue is managed. Postqueue needs no knowledge of feeds for this. Its overview is a plain WP_List_Table, so the column goes in through the two hooks a column is added to any core list table with, and without this plugin the column is simply absent. Verified both ways: with the plugin active the header and a cell per row appear, deactivating it removes them, and Postqueue's own sorting, search, row actions and bulk actions are untouched. The address comes from get_feed_link(), so it follows the site: measured as /feed/<slug>/ with permalinks enabled and ?feed=<slug> without, which is the pair this plugin serves. Shown as the path rather than the whole URL, which does not fit a table column; the link carries the full one. Also the first translatable string this plugin has ever had, so the text domain is loaded and de_DE, de_CH and de_CH_informal catalogues are in place. Two things ride along in the diff. Seven files carried the executable bit since the 2017 repository - PHP files and .gitignore among them - and lose it here. And the payload check now asks twice whether the dev wrapper got shipped: by file name, and by the (DEV) marker in its header, which stays with the file even if a name changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under Tools > Postqueues, where Postqueue lists the queues, a Feed column now gives each queue's address, so it can be read and copied where the queue is managed.
Postqueue needs no knowledge of feeds for this. Its overview is a plain WP_List_Table, so the column goes in through the two hooks a column is added to any core list table with, and without this plugin the column is simply absent. Verified both ways: with the plugin active the header and a cell per row appear, deactivating it removes them, and Postqueue's own sorting, search, row actions and bulk actions are untouched.
The address comes from get_feed_link(), so it follows the site: measured as /feed// with permalinks enabled and ?feed= without, which is the pair this plugin serves. Shown as the path rather than the whole URL, which does not fit a table column; the link carries the full one.
Also the first translatable string this plugin has ever had, so the text domain is loaded and de_DE, de_CH and de_CH_informal catalogues are in place.
Two things ride along in the diff. Seven files carried the executable bit since the 2017 repository - PHP files and .gitignore among them - and lose it here. And the payload check now asks twice whether the dev wrapper got shipped: by file name, and by the (DEV) marker in its header, which stays with the file even if a name changes.