docs(extension-chrome): document folder-delete cascade as known limitation#28
Merged
Merged
Conversation
…ation Closing #2 with documentation rather than implementation. Chrome doesn't emit child onRemoved events when a parent folder is deleted, and the folder node itself has no ULID mapping — so the listener can't cascade. Implementing this requires either a persisted folder→children index maintained on every event + reconcile (significant complexity) or poll-time orphan detection (extra GitHub round-trips). Both are disproportionate to a rare and recoverable user action. README now spells out the behavior + workarounds. Issue #2 stays findable for any future contributor who wants to revisit. Closes #2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing #2 with documentation rather than implementation.
When you delete a folder in Chrome containing synced bookmarks,
onRemovedfires for the folder node only — Chrome doesn't emit child events (the subtree is gone by the time the listener fires). The folder has no ULID mapping, so the listener no-ops. The bookmarks remain in remotebookmarks.json; on the next 5-min poll they reappear locally under the bookmarks bar.Why not implement
Correct cascade requires either (a) a persisted folder→children index maintained on every event + reconcile, or (b) poll-time orphan detection (extra round-trips). Both are substantial work for a rare and recoverable user action. The workarounds (delete from GitHub directly, or delete bookmarks individually before the folder) are reasonable for v1.
This PR adds a 'Known limitations' section to
packages/extension-chrome/README.mdcalling out the behavior + workarounds. The issue stays findable as #2 for any future contributor who wants to revisit.Closes #2