docs: clean up stale refs after Firefox refactor#36
Merged
Conversation
Caught by the post-merge code review (PR #32 followup): - packages/extension-chrome/README.md 'Automated tests' section: drops the dead 'pnpm --filter @gitmarks/extension-chrome test' command (the test script and vitest.config.ts moved to extension-shared) and corrects '97 unit tests' to 96. Now points readers at extension-shared for the unit suite and keeps extension-chrome e2e + typecheck commands. - README.md 'Development' section: same 'pnpm --filter extension-chrome test' → 'extension-shared test' fix. - CLAUDE.md '@gitmarks/extension-chrome' architecture section: rewritten as two sections — extension-shared (canonical owner of src/lib/, background, popup, options) and the two browser shells (Chrome + Firefox). Removes the stale claim that the libs live under extension-chrome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-merge code review of #32 caught three doc drift items:
packages/extension-chrome/README.mdclaimed '97 unit tests' (actual: 96 — chrome smoke test was deleted in FF-1) and pointed readers at the now-removedpnpm --filter @gitmarks/extension-chrome testscript (vitest moved to extension-shared).README.md'Development' section had the same deadextension-chrome testcommand.CLAUDE.mdstill described@gitmarks/extension-chromeas owner ofsrc/lib/— that moved to@gitmarks/extension-sharedin the refactor.This PR fixes those refs. The reviewer's other flags became tracked follow-up issues (HTML duplication #33, type-position consistency #34, test-assertion namespace fragility #35) rather than fix-now scope.
Test plan: typecheck + tests green locally; CI will confirm.