Improve KDE Plasma icon and notification compatibility #23
Open
KeremDurgut wants to merge 2 commits into
Open
Conversation
Fixed the issue where kde app icons were invinsible and selected more appropriate icons from breeze.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves pardus-update's compatibility with KDE Plasma.
Fix tray icons on KDE
The tray icon was invisible because the app was trying to select an adwaita icon on KDE Plasma environment. This issue was solved by changing the negative
if not xfce_desktop:check to a positiveif gnome_desktop:check and adding aif kde_desktopcheck.Fix notifications on KDE
Also the app's notifications were not working properly in KDE Plasma due to Plasma not detecting the correct application information. Solved this issue by adding a hint to the notification object, indicating that it is a desktop entry.
Testing
I have tested this PR on KDE Plasma as well as the existing Pardus desktop environments. No bugs or faults were detected and i have uploaded the screenshots below.
xfce notification after update:
gnome notification after update:
