fix(tests): update container startup tests for preiweb service rename - #351
Merged
Merged
Conversation
test_container_startup.py still looked up docker-compose.yml's web
service by its old key ("web"), which became "preiweb" in 7253ef4
(rename compose service web to preiweb for observability clarity).
The compose file's actual config was never wrong — the test's dict
lookups just returned {} for everything, failing 3 assertions on
every PR's Integration Tests job regardless of what the PR touched.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/test_container_startup.pystill looks updocker-compose.yml's web service by its old key"web", which became"preiweb"in chore: rename compose service web to preiweb for observability clarity #344 (rename compose service web to preiweb for observability clarity)..get("services", {}).get("web", {})lookups just silently returned{}, failing 3 assertions unconditionally on every PR's Integration Tests job regardless of what the PR actually touched.Test plan
python -m pytest tests/test_container_startup.py -v— 9/9 pass (was 3 failed, 6 passed)pre-commit run --files tests/test_container_startup.py— clean"web"service-key references anywhere in the repo (grep -rnacross.py/.yml)