fix(ci): remove commit-msg hook, add live model resolver - #375
Closed
paruff wants to merge 0 commit into
Closed
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| address, | ||
| city, | ||
| state, | ||
| zip_code, |
| ) | ||
| return cast(Decimal, result["median_rent"]) | ||
| except RentometerError as exc: | ||
| logger.warning("Rentometer lookup failed for %s: %s", zip_code, exc) |
paruff
force-pushed
the
fix/opencode-commit-hook-and-model-resolver
branch
from
August 21, 2026 07:51
38a289b to
8849d12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the exact bug that lost real work on this repo's own opencode validation run today (issue #369): opencode found and fixed a genuine 47-file Python 2
except A, B:syntax bug plus the requested feature, 815 tests passing — thengit commitfailed the localcommitizencommit-msg hook (no type prefix), and since the hook blocks commit creation rather than just flagging it after, there was nothing for a backstop to fix. All of that work was lost when the runner tore down.This repo's
opencode.ymlnever had a commit-msg-hook-install step (that pattern only existed on fawkes), so there's nothing to remove here — this PR is the model resolver and the routing test, ported fromparuff/fawkes(#1630 there) after the prei validation run's failure motivated both fixes.Replaces the hardcoded
model:string with aResolve modelstep that verifies the preferred model against the livemodels.devcatalog before use and falls back (with a visible::warning::) to another free tool-calling model on the same provider if it's been renamed or removed.Adds
tests/unit/test_opencode_routing.py, testing the realif:trigger expression and the resolver'sPREFERRED=literals extracted directly from the workflow file. Addednoqa: S307on theeval()call since this repo'sruffconfig enables that rule (fawkes's doesn't).Test plan
ruff check/ruff formatpassmypypasses (confirmed via the pre-commit hook's environment — my direct CLI run hit a Django-plugin init error unrelated to this file)pytest.inineeds plugins not installed in this session)/ocon a test issue to confirm end-to-end, including that the commit actually lands now🤖 Generated with Claude Code