Skip to content

Support non-Li-ion models#16

Open
DavidMStraub wants to merge 11 commits into
pathsim:masterfrom
DavidMStraub:non_li_ion
Open

Support non-Li-ion models#16
DavidMStraub wants to merge 11 commits into
pathsim:masterfrom
DavidMStraub:non_li_ion

Conversation

@DavidMStraub
Copy link
Copy Markdown
Collaborator

@DavidMStraub DavidMStraub commented May 20, 2026

Fixes #15.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds broader PyBaMM model-family compatibility (lead-acid + equivalent-circuit, and documented sodium-ion limitations) so the existing PathSim battery cell blocks can be used beyond lithium-ion models (Fixes #15).

Changes:

  • Resolve per-model variable-name aliases (voltage/heating/temperature) and support direct-SoC outputs when discharge-capacity isn’t available.
  • Add construction/smoke tests for lead-acid and ECM models, and document expected failures for sodium-ion BasicDFN with current blocks.
  • Expand CI to test a Python/PyBaMM version matrix and add a Python 3.14 trove classifier.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/pathsim_batt/cells/pybamm_cell.py Adds variable-alias resolution, model-family-specific build handling, and alternate SOC computation paths.
tests/cells/test_other_chemistries.py New smoke/behavior tests for lead-acid + ECM, and boundary/exception documentation tests for sodium-ion BasicDFN.
pyproject.toml Adds Python 3.14 classifier metadata.
.github/workflows/test.yml Expands test matrix across PyBaMM versions and Python versions; disables fail-fast.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/pathsim_batt/cells/pybamm_cell.py
Comment thread src/pathsim_batt/cells/pybamm_cell.py Outdated
Comment thread .github/workflows/test.yml Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comment thread src/pathsim_batt/cells/pybamm_cell.py
@DavidMStraub DavidMStraub marked this pull request as ready for review May 20, 2026 15:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Comment thread tests/cells/_helpers.py
Comment thread tests/cells/_helpers.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make compatible with non-Li-ion models

2 participants