feat: added skill to deploy to github pages using pfcli#114
Conversation
📝 WalkthroughWalkthroughA new Changespf-github-pages-deploy Skill
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Warning Review ran into problems🔥 ProblemsLinked repositories: Your configuration references 1 linked repositories, but your current plan allows 0. Analyzed ``, skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/react/skills/pf-github-pages-deploy/SKILL.md`:
- Around line 1-4: The SKILL.md frontmatter is missing the required
`disable-model-invocation: true` flag. Since the pf-github-pages-deploy skill
executes a side-effecting operation (deploying to GitHub Pages), you must add
`disable-model-invocation: true` to the YAML frontmatter block between the
dashes at the top of the file, alongside the existing name and description
fields. This flag prevents unintended programmatic invocation of the deploy
command and aligns with PatternFly coding guidelines for skills that perform
deployments or other external operations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a1081aa2-ae58-4a17-8684-2aaa41203376
📒 Files selected for processing (3)
PLUGINS.mdplugins/react/README.mdplugins/react/skills/pf-github-pages-deploy/SKILL.md
| --- | ||
| name: pf-github-pages-deploy | ||
| description: Deploy a PatternFly React project to GitHub Pages using pfcli deploy. Use when publishing a prototype, sharing a demo URL, deploying to GitHub Pages, or when the user mentions pfcli deploy. | ||
| --- |
There was a problem hiding this comment.
Critical: Add disable-model-invocation: true to frontmatter.
This skill executes pfcli deploy which deploys to GitHub Pages—a side-effecting operation. Per PatternFly coding guidelines and documented convention, SKILL.md frontmatter must include disable-model-invocation: true for any skill that performs deployments, writes files, creates issues, or posts external content. Omitting this flag creates a security risk by allowing unintended programmatic invocation of the deploy command.
🔒 Proposed fix to add the disable-model-invocation flag
---
name: pf-github-pages-deploy
description: Deploy a PatternFly React project to GitHub Pages using pfcli deploy. Use when publishing a prototype, sharing a demo URL, deploying to GitHub Pages, or when the user mentions pfcli deploy.
+disable-model-invocation: true
---🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@plugins/react/skills/pf-github-pages-deploy/SKILL.md` around lines 1 - 4, The
SKILL.md frontmatter is missing the required `disable-model-invocation: true`
flag. Since the pf-github-pages-deploy skill executes a side-effecting operation
(deploying to GitHub Pages), you must add `disable-model-invocation: true` to
the YAML frontmatter block between the dashes at the top of the file, alongside
the existing name and description fields. This flag prevents unintended
programmatic invocation of the deploy command and aligns with PatternFly coding
guidelines for skills that perform deployments or other external operations.
Sources: Coding guidelines, Learnings
Added a new skill to deploy to github pages using pfcli.
Summary by CodeRabbit