Skip to content

feat: added skill to deploy to github pages using pfcli#114

Open
dlabaj wants to merge 1 commit into
patternfly:mainfrom
dlabaj:deploy
Open

feat: added skill to deploy to github pages using pfcli#114
dlabaj wants to merge 1 commit into
patternfly:mainfrom
dlabaj:deploy

Conversation

@dlabaj

@dlabaj dlabaj commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Added a new skill to deploy to github pages using pfcli.

Summary by CodeRabbit

  • Documentation
    • Added complete documentation for a new PatternFly React GitHub Pages deployment skill enabling automated app deployments. Includes prerequisites, deployment workflow, detailed instructions, command-line flag reference with examples, and comprehensive troubleshooting guide.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

A new pf-github-pages-deploy skill is added to the PatternFly React plugin. This includes a new entry in the top-level PLUGINS.md skills table, updated skill listing and file structure in plugins/react/README.md, and a new SKILL.md documenting prerequisites, pfcli deploy usage, CLI flags, and troubleshooting.

Changes

pf-github-pages-deploy Skill

Layer / File(s) Summary
Skill index entries
PLUGINS.md, plugins/react/README.md
Adds the pf-github-pages-deploy row to the top-level skills table and registers the skill with its identifier and description in the React plugin README, including the new directory in the file structure example.
SKILL.md content
plugins/react/skills/pf-github-pages-deploy/SKILL.md
New file defining skill front matter, prerequisites (PatternFly CLI, GitHub CLI auth, origin remote, package.json build script), step-by-step deploy workflow, pfcli deploy CLI flags table, React Router subpath guidance, post-deploy URL format, and a troubleshooting table.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • patternfly/ai-helpers#50: Both PRs modify the React plugin skill catalog in PLUGINS.md and plugins/react/README.md, with this PR adding the new /react:pf-github-pages-deploy entry under the same react namespace.

Suggested reviewers

  • jpuzz0
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding a new skill for deploying to GitHub Pages using pfcli, which directly matches the core objective of this PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch deploy

Warning

Review ran into problems

🔥 Problems

Linked repositories: Your configuration references 1 linked repositories, but your current plan allows 0. Analyzed ``, skipped anthropics/claude-plugins-official.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@plugins/react/skills/pf-github-pages-deploy/SKILL.md`:
- Around line 1-4: The SKILL.md frontmatter is missing the required
`disable-model-invocation: true` flag. Since the pf-github-pages-deploy skill
executes a side-effecting operation (deploying to GitHub Pages), you must add
`disable-model-invocation: true` to the YAML frontmatter block between the
dashes at the top of the file, alongside the existing name and description
fields. This flag prevents unintended programmatic invocation of the deploy
command and aligns with PatternFly coding guidelines for skills that perform
deployments or other external operations.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a1081aa2-ae58-4a17-8684-2aaa41203376

📥 Commits

Reviewing files that changed from the base of the PR and between bd8becd and f509815.

📒 Files selected for processing (3)
  • PLUGINS.md
  • plugins/react/README.md
  • plugins/react/skills/pf-github-pages-deploy/SKILL.md

Comment on lines +1 to +4
---
name: pf-github-pages-deploy
description: Deploy a PatternFly React project to GitHub Pages using pfcli deploy. Use when publishing a prototype, sharing a demo URL, deploying to GitHub Pages, or when the user mentions pfcli deploy.
---

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Critical: Add disable-model-invocation: true to frontmatter.

This skill executes pfcli deploy which deploys to GitHub Pages—a side-effecting operation. Per PatternFly coding guidelines and documented convention, SKILL.md frontmatter must include disable-model-invocation: true for any skill that performs deployments, writes files, creates issues, or posts external content. Omitting this flag creates a security risk by allowing unintended programmatic invocation of the deploy command.

🔒 Proposed fix to add the disable-model-invocation flag
 ---
 name: pf-github-pages-deploy
 description: Deploy a PatternFly React project to GitHub Pages using pfcli deploy. Use when publishing a prototype, sharing a demo URL, deploying to GitHub Pages, or when the user mentions pfcli deploy.
+disable-model-invocation: true
 ---
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@plugins/react/skills/pf-github-pages-deploy/SKILL.md` around lines 1 - 4, The
SKILL.md frontmatter is missing the required `disable-model-invocation: true`
flag. Since the pf-github-pages-deploy skill executes a side-effecting operation
(deploying to GitHub Pages), you must add `disable-model-invocation: true` to
the YAML frontmatter block between the dashes at the top of the file, alongside
the existing name and description fields. This flag prevents unintended
programmatic invocation of the deploy command and aligns with PatternFly coding
guidelines for skills that perform deployments or other external operations.

Sources: Coding guidelines, Learnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant