feat(PF-4273): add eval for pf-unit-test-generator skill#115
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (7)
📝 WalkthroughWalkthroughAdds a Changespf-unit-test-generator Eval Suite
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsLinked repositories: Your configuration references 1 linked repositories, but your current plan allows 0. Analyzed ``, skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
eval/pf-unit-test-generator/cases/library-tooltip/Tooltip.tsx (1)
1-1: ⚡ Quick winUse kebab-case for this fixture filename.
Tooltip.tsxviolates the repository naming rule. Rename it totooltip.tsxand update case references accordingly to keep fixture linkage intact.
As per coding guidelines, "Use kebab-case for directory and file names".🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@eval/pf-unit-test-generator/cases/library-tooltip/Tooltip.tsx` at line 1, Rename the file from Tooltip.tsx to tooltip.tsx to comply with the kebab-case naming convention for fixture files. After renaming, search the codebase for any references to the Tooltip.tsx filename (including import statements, path references, and fixture linkage configurations) and update them to use the new tooltip.tsx filename to maintain proper fixture linkage and consistency.Source: Coding guidelines
eval/pf-unit-test-generator/cases/library-wizard-orchestration/Wizard.tsx (1)
1-1: ⚡ Quick winUse kebab-case for this fixture filename.
Wizard.tsxviolates the repository naming rule. Rename it towizard.tsxand update case references so the fixture mapping remains correct.
As per coding guidelines, "Use kebab-case for directory and file names".🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@eval/pf-unit-test-generator/cases/library-wizard-orchestration/Wizard.tsx` at line 1, The file Wizard.tsx uses PascalCase instead of the required kebab-case naming convention. Rename the file from Wizard.tsx to wizard.tsx and update all imports and references throughout the codebase that point to this file to use the new lowercase filename to maintain correct fixture mapping.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@eval/pf-unit-test-generator/cases/library-tooltip/Tooltip.tsx`:
- Line 1: Rename the file from Tooltip.tsx to tooltip.tsx to comply with the
kebab-case naming convention for fixture files. After renaming, search the
codebase for any references to the Tooltip.tsx filename (including import
statements, path references, and fixture linkage configurations) and update them
to use the new tooltip.tsx filename to maintain proper fixture linkage and
consistency.
In `@eval/pf-unit-test-generator/cases/library-wizard-orchestration/Wizard.tsx`:
- Line 1: The file Wizard.tsx uses PascalCase instead of the required kebab-case
naming convention. Rename the file from Wizard.tsx to wizard.tsx and update all
imports and references throughout the codebase that point to this file to use
the new lowercase filename to maintain correct fixture mapping.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7760b41e-4fc9-4554-ac3b-ff1c094aa107
📒 Files selected for processing (11)
.gitignoreeval/pf-unit-test-generator/cases/consumer-with-children/ServiceCard.tsxeval/pf-unit-test-generator/cases/consumer-with-children/annotations.yamleval/pf-unit-test-generator/cases/consumer-with-children/input.yamleval/pf-unit-test-generator/cases/library-tooltip/Tooltip.tsxeval/pf-unit-test-generator/cases/library-tooltip/annotations.yamleval/pf-unit-test-generator/cases/library-tooltip/input.yamleval/pf-unit-test-generator/cases/library-wizard-orchestration/Wizard.tsxeval/pf-unit-test-generator/cases/library-wizard-orchestration/annotations.yamleval/pf-unit-test-generator/cases/library-wizard-orchestration/input.yamleval/pf-unit-test-generator/eval.yaml
Add first eval using agent-eval-harness to verify the skill's consumer vs library context detection (mocking decisions). 3 test cases, 4 inline check judges, all passing at 100%.
d437ddb to
72b0911
Compare
Summary
First eval using agent-eval-harness. Tests the skill's unique value: detecting consumer vs library context and making the right mocking decisions.
Run with:
/eval-run --config eval/pf-unit-test-generator/eval.yamlScoring results
Summary by CodeRabbit
New Features
Chores
.gitignoreto ignore evaluation run output.