feat: breaking change skill#116
Conversation
📝 WalkthroughWalkthroughA new Changespf-react-breaking-changes Skill
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Warning Review ran into problems🔥 ProblemsLinked repositories: Your configuration references 1 linked repositories, but your current plan allows 0. Analyzed ``, skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/migration/skills/pf-react-breaking-changes/SKILL.md`:
- Around line 1-7: The SKILL.md file frontmatter is missing the required
`disable-model-invocation: true` field. Since this skill writes a markdown
report file to the project root (pf-react-breaking-changes-report.md), it has
filesystem side effects and must declare this flag to prevent AI models from
invoking it programmatically. Add the `disable-model-invocation: true` field to
the YAML frontmatter in the skill definition.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1d3a40c1-169c-4b76-b68d-25f5323b3a0a
📒 Files selected for processing (4)
PLUGINS.mdplugins/migration/README.mdplugins/migration/skills/pf-react-breaking-changes/SKILL.mdplugins/migration/skills/pf-react-breaking-changes/references/report-template.md
| --- | ||
| name: pf-react-breaking-changes | ||
| description: >- | ||
| Scan code for @patternfly/react-* API breaking changes and produce a markdown | ||
| report. Use when upgrading PatternFly React versions, auditing component API | ||
| usage, or checking for removed props, renamed components, or import path changes. | ||
| --- |
There was a problem hiding this comment.
Add disable-model-invocation: true to frontmatter — skill has side effects.
This skill writes a markdown report file to the project root (line 119: pf-react-breaking-changes-report.md), which is a filesystem side effect. Without disable-model-invocation: true, an AI model could invoke the skill programmatically without explicit user request. This field is a required PatternFly convention for skills that mutate files or system state. As per coding guidelines and retrieved learnings, skills with side effects must declare this flag.
🛡️ Proposed fix to add `disable-model-invocation: true`
---
name: pf-react-breaking-changes
+disable-model-invocation: true
description: >-
Scan code for `@patternfly/react-`* API breaking changes and produce a markdown
report. Use when upgrading PatternFly React versions, auditing component API📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| --- | |
| name: pf-react-breaking-changes | |
| description: >- | |
| Scan code for @patternfly/react-* API breaking changes and produce a markdown | |
| report. Use when upgrading PatternFly React versions, auditing component API | |
| usage, or checking for removed props, renamed components, or import path changes. | |
| --- | |
| --- | |
| name: pf-react-breaking-changes | |
| disable-model-invocation: true | |
| description: >- | |
| Scan code for `@patternfly/react-`* API breaking changes and produce a markdown | |
| report. Use when upgrading PatternFly React versions, auditing component API | |
| usage, or checking for removed props, renamed components, or import path changes. | |
| --- |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@plugins/migration/skills/pf-react-breaking-changes/SKILL.md` around lines 1 -
7, The SKILL.md file frontmatter is missing the required
`disable-model-invocation: true` field. Since this skill writes a markdown
report file to the project root (pf-react-breaking-changes-report.md), it has
filesystem side effects and must declare this flag to prevent AI models from
invoking it programmatically. Add the `disable-model-invocation: true` field to
the YAML frontmatter in the skill definition.
Sources: Coding guidelines, Learnings
1 participant
Created skill that checks for breaking changes by react.
Summary by CodeRabbit