Skip to content

ci: harden publish path and add release-automation helpers - #17345

Merged
denolfe merged 27 commits into
mainfrom
ci/rework-phase-1
Jul 20, 2026
Merged

ci: harden publish path and add release-automation helpers#17345
denolfe merged 27 commits into
mainfrom
ci/rework-phase-1

Conversation

@denolfe

@denolfe denolfe commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Phase 1 of the release-automation rework for v4. It makes changes to the release tooling that are safe to merge while the current release flow keeps running. Some new helpers are added but do not have callers yet. Entry scripts and workflows follow in later phases.

Resolves PYLD-3215

Motivation

The release process runs locally and interactively today. That gates releases on a single maintainer and a manual branch freeze. The target design splits the bump from the publish across two workflows joined by a git tag. It also moves publishing to tokenless npm OIDC. Migrating is time-sensitive: npm is deprecating the token path the current flow relies on. This phase prepares the tooling without altering the live flow.

Key Changes

  • Hardened publish path
    • Publishing now uses a non-throwing subprocess call. Errors return instead of aborting, so the retry and post-failure recheck both run.
    • A registry pre-check skips already-published packages. An already-published error from npm also counts as success. Together these make a re-run safe on a partial publish.
    • The registry check separates "not published" (404) from transient errors. Transient errors now surface instead of reading as absent.
  • Fail-fast, topological publish
    • The publish sequence stops at the first failed package. A partial publish will only ever leave packages with all dependencies fulfilled.
    • The publish list is reordered so every dependency precedes its dependents.
  • Changelog range selection
    • A new helper picks the changelog base. It uses the latest published tag on the same release line. A tagged-but-unpublished version is tolerated without mutating any tag.
  • Draft release upsert
    • Creating the draft GitHub release now finds an existing draft. It updates that draft instead of always creating a new one. It refuses to overwrite an already-published release.
  • Version bump groundwork
    • The version bump now accepts a prerelease identifier and returns the computed version. The change is backward-compatible, so existing callers are unaffected.
    • The current canary mechanism stays in place until the later cutover.
  • Publish surface cleanup
    • The workspace's sole publish orchestrator is renamed from publishSync to publish. The prior unused parallel publish was removed.
  • Push-with-rebase-retry helper
    • A new helper pushes the bump commit and tag. On a non-fast-forward rejection it rebases and retries. Unused until the bump entry script lands.
  • Release URL handling
    • Release-note generation no longer opens a browser. It prints the prefilled release URL instead.

Design Decisions

  • Additive and bug-fix only. The live flow stays untouched. The one change that would break canary (removing its registry-fetch bump branch) is deferred to the cutover phase. Everything here lands independently.
  • Fail-fast and topological order are paired deliberately. Publishing stops at the first failure. That stop is what makes a partial publish a valid dependency prefix. Reordering alone would still let a dependent ship past a failed dependency.
  • New helpers The changelog-base and rebase-retry helpers have no callers in this phase. Later entry scripts wire in already-verified pieces.
  • Idempotent re-runs A re-run relies on the registry pre-check and the already-published publish error. It stays correct even when the CDN-cached registry read lags the write path.

References / Links

denolfe added 20 commits July 14, 2026 16:31
@denolfe
fix: open release URL only when openReleaseUrl is true
3e05a67
@denolfe
fix: upsert draft GitHub release instead of always creating
3c28dd1
@denolfe
feat: add isVersionPublished registry check
10b623b
@denolfe
feat: idempotent publish with single retry
41da846
@denolfe
refactor: fail-fast publish sequence
86d3d23
@denolfe
chore: remove orphaned PublishResult type from getWorkspace
56a1947
@denolfe
refactor: reorder publish list topologically
79caa30
@denolfe
chore: guard publish-list topo spec against vacuous pass
f2f5826
@denolfe
feat: bumpVersion accepts preid and returns the new version
45ac21f
@denolfe
feat: add pushWithRebaseRetry helper
3f4e8c3
@denolfe
fix: correct pushWithRebaseRetry non-ff handling and guards
bade6bc
@denolfe
chore: assert on call count instead of indexing untyped mock in pushW…
a4cf4c8 
…ithRebaseRetry spec
@denolfe
feat: add findChangelogBaseTag helper
0c2d47b
@denolfe
test: lock in cross-major exclusion in findChangelogBaseTag
5fb6fa9
@denolfe
chore: address code-review minors in releaser (error msg, publish pre…
7b7d59a 
…-check, retry guard, docs)
@denolfe
chore: harden releaser publish path (reachable retry/recovery + regis…
6841b7c 
…try error handling)

- Replace execa (reject:true) with child_process.spawn for publish calls so the
  non-zero-exit retry and 'landed despite error' recovery are actually reachable
- isVersionPublished: distinguish 404 (not published) from other statuses (throw)
  instead of conflating registry errors with 'not published'
- Make the pre-publish idempotency check non-fatal (warn + proceed on error)
- Detect npm EPUBLISHCONFLICT from publish output as an authoritative
  already-published signal, short-circuiting a doomed retry
@denolfe
chore: refuse to overwrite a published GitHub release in createDraftG…
0e2713d 
…itHubRelease

Only PATCH a matched release when it is still a draft; a matching published
release means the tag already shipped, so throw rather than clobber its live
notes (the caller falls back to the manual-link path).
@denolfe
chore: bound findReleaseByTag to the newest page of releases
971073f 
Releases list newest-first by created_at and a draft we would update is created
recently, so it sits on the first page. Scan only the newest page (was an
unbounded walk of the full ~550-release history) and warn if a full page has no
match, keeping the lookup O(1) as the release history grows.
@denolfe
chore: remove openReleaseUrl option from generateReleaseNotes
cb706c8 
The release URL is written to stdout, so auto-opening a browser is non-essential
and could throw on a headless host (aborting the release before the publish
confirm). Drop the option, the open() call, the CLI flag, and the now-unused
'open' dependency.
@denolfe
chore: fail clearly when turbo emits no JSON in publish-list topo test
a55430f 
Assert a JSON object is present before slicing so a turbo error or flag change
surfaces diagnosably instead of an opaque 'Unexpected end of JSON input'.
@github-actions

github-actions Bot commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📦 esbuild Bundle Analysis for payload

This analysis was generated by esbuild-bundle-analyzer. 🤖

Meta File Out File Size (raw) Note
packages/next/meta_index.json esbuild/index.js 201.89 KB ✅ No change
packages/payload/meta_index.json esbuild/index.js 1.41 MB ⚠️ +4.38 KB (+0.3%)
packages/payload/meta_shared.json esbuild/exports/shared.js 213.20 KB ✅ -26 B (-0.0%)
packages/richtext-lexical/meta_client.json esbuild/exports/client_optimized/index.js 285.56 KB ✅ No change
packages/ui/meta_client.json esbuild/exports/client_optimized/index.js 36.16 KB ✅ No change
packages/ui/meta_shared.json esbuild/exports/shared_optimized/index.js 18.95 KB ✅ No change
Largest paths These visualization shows top 20 largest paths in the bundle.

Meta file: packages/next/meta_index.json, Out file: esbuild/index.js

Path Size
../../node_modules ${{\color{Goldenrod}{ ████████████████████████▋ }}}$ 98.9%, 197.86 KB
dist/adapters/router.js ${{\color{Goldenrod}{ }}}$ 0.4%, 718 B
dist/adapters/server.js ${{\color{Goldenrod}{ }}}$ 0.3%, 533 B
dist/adapters/layout.js ${{\color{Goldenrod}{ }}}$ 0.3%, 526 B
dist/adapters/views.js ${{\color{Goldenrod}{ }}}$ 0.2%, 409 B
dist/esbuildEntry.js ${{\color{Goldenrod}{ }}}$ 0.0%, 0 B

Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js

Path Size
../../node_modules ${{\color{Goldenrod}{ █████████████████▏ }}}$ 68.8%, 964.37 KB
dist/fields/hooks ${{\color{Goldenrod}{ ▊ }}}$ 3.2%, 44.37 KB
dist/collections/operations ${{\color{Goldenrod}{ ▊ }}}$ 3.0%, 42.69 KB
dist/utilities/configToJSONSchema.js ${{\color{Goldenrod}{ ▎ }}}$ 1.1%, 15.99 KB
dist/auth/operations ${{\color{Goldenrod}{ ▎ }}}$ 1.1%, 15.68 KB
dist/fields/config ${{\color{Goldenrod}{ ▎ }}}$ 1.0%, 13.79 KB
dist/globals/operations ${{\color{Goldenrod}{ ▎ }}}$ 1.0%, 13.36 KB
dist/queues/operations ${{\color{Goldenrod}{ ▏ }}}$ 0.9%, 12.63 KB
dist/fields/validations.js ${{\color{Goldenrod}{ ▏ }}}$ 0.8%, 10.73 KB
dist/bin/generateImportMap ${{\color{Goldenrod}{ ▏ }}}$ 0.7%, 9.84 KB
dist/collections/config ${{\color{Goldenrod}{ ▏ }}}$ 0.7%, 9.30 KB
dist/config/orderable ${{\color{Goldenrod}{ ▏ }}}$ 0.6%, 8.07 KB
dist/index.js ${{\color{Goldenrod}{ ▏ }}}$ 0.6%, 7.96 KB
dist/uploads/fetchAPI-multipart ${{\color{Goldenrod}{ ▏ }}}$ 0.6%, 7.84 KB
dist/hierarchy/utils ${{\color{Goldenrod}{ ▏ }}}$ 0.5%, 7.64 KB
dist/database/migrations ${{\color{Goldenrod}{ ▏ }}}$ 0.5%, 7.55 KB
dist/config/sanitize.js ${{\color{Goldenrod}{ ▏ }}}$ 0.5%, 6.98 KB
dist/collections/endpoints ${{\color{Goldenrod}{ }}}$ 0.4%, 6.12 KB
dist/queues/config ${{\color{Goldenrod}{ }}}$ 0.4%, 5.59 KB
dist/uploads/endpoints ${{\color{Goldenrod}{ }}}$ 0.4%, 5.56 KB
(other) ${{\color{Goldenrod}{ ███████▊ }}}$ 31.2%, 437.61 KB

Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js

Path Size
../../node_modules ${{\color{Goldenrod}{ █████████████████▉ }}}$ 71.9%, 150.13 KB
dist/fields/validations.js ${{\color{Goldenrod}{ █▎ }}}$ 5.1%, 10.73 KB
dist/fields/config ${{\color{Goldenrod}{ ▋ }}}$ 2.8%, 5.82 KB
dist/utilities/traverseFields.js ${{\color{Goldenrod}{ ▌ }}}$ 2.1%, 4.44 KB
dist/collections/config ${{\color{Goldenrod}{ ▍ }}}$ 1.6%, 3.32 KB
dist/config/orderable ${{\color{Goldenrod}{ ▍ }}}$ 1.5%, 3.13 KB
dist/fields/baseFields ${{\color{Goldenrod}{ ▎ }}}$ 1.3%, 2.79 KB
dist/utilities/deepCopyObject.js ${{\color{Goldenrod}{ ▎ }}}$ 1.3%, 2.69 KB
dist/config/client.js ${{\color{Goldenrod}{ ▎ }}}$ 1.3%, 2.68 KB
dist/auth/cookies.js ${{\color{Goldenrod}{ ▏ }}}$ 0.7%, 1.55 KB
dist/utilities/flattenTopLevelFields.js ${{\color{Goldenrod}{ ▏ }}}$ 0.7%, 1.41 KB
dist/utilities/getVersionsConfig.js ${{\color{Goldenrod}{ ▏ }}}$ 0.5%, 1.04 KB
dist/globals/config ${{\color{Goldenrod}{ }}}$ 0.4%, 939 B
dist/utilities/flattenAllFields.js ${{\color{Goldenrod}{ }}}$ 0.4%, 793 B
dist/utilities/unflatten.js ${{\color{Goldenrod}{ }}}$ 0.4%, 779 B
dist/utilities/sanitizeUserDataForEmail.js ${{\color{Goldenrod}{ }}}$ 0.3%, 713 B
dist/auth/extractJWT.js ${{\color{Goldenrod}{ }}}$ 0.3%, 696 B
dist/utilities/getFieldPermissions.js ${{\color{Goldenrod}{ }}}$ 0.3%, 651 B
dist/errors/ValidationError.js ${{\color{Goldenrod}{ }}}$ 0.3%, 577 B
dist/bin/generateImportMap ${{\color{Goldenrod}{ }}}$ 0.3%, 561 B
(other) ${{\color{Goldenrod}{ ███████ }}}$ 28.1%, 58.59 KB

Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js

Path Size
dist/features/blocks ${{\color{Goldenrod}{ ███▎ }}}$ 13.2%, 37.20 KB
dist/lexical/ui ${{\color{Goldenrod}{ ███ }}}$ 12.1%, 34.16 KB
dist/lexical/plugins ${{\color{Goldenrod}{ ██▉ }}}$ 11.8%, 33.18 KB
dist/features/experimental_table ${{\color{Goldenrod}{ ██▍ }}}$ 9.6%, 27.22 KB
dist/features/link ${{\color{Goldenrod}{ █▋ }}}$ 6.7%, 18.82 KB
dist/features/toolbars ${{\color{Goldenrod}{ █▍ }}}$ 5.9%, 16.58 KB
dist/features/upload ${{\color{Goldenrod}{ █▎ }}}$ 5.0%, 14.09 KB
dist/features/textState ${{\color{Goldenrod}{ ▉ }}}$ 3.9%, 11.08 KB
dist/lexical/utils ${{\color{Goldenrod}{ ▉ }}}$ 3.5%, 10.02 KB
dist/features/relationship ${{\color{Goldenrod}{ ▊ }}}$ 3.4%, 9.61 KB
dist/features/converters ${{\color{Goldenrod}{ ▊ }}}$ 3.0%, 8.36 KB
dist/utilities/fieldsDrawer ${{\color{Goldenrod}{ ▋ }}}$ 2.9%, 8.12 KB
dist/features/debug ${{\color{Goldenrod}{ ▋ }}}$ 2.6%, 7.40 KB
dist/lexical/config ${{\color{Goldenrod}{ ▍ }}}$ 1.8%, 5.14 KB
dist/features/lists ${{\color{Goldenrod}{ ▎ }}}$ 1.3%, 3.64 KB
dist/features/format ${{\color{Goldenrod}{ ▎ }}}$ 1.2%, 3.28 KB
dist/lexical/LexicalEditor.js ${{\color{Goldenrod}{ ▎ }}}$ 1.1%, 3.23 KB
dist/features/horizontalRule ${{\color{Goldenrod}{ ▎ }}}$ 1.1%, 3.18 KB
dist/field/Field.js ${{\color{Goldenrod}{ ▎ }}}$ 1.0%, 2.88 KB
dist/lexical/nodes ${{\color{Goldenrod}{ ▏ }}}$ 0.9%, 2.66 KB
(other) ${{\color{Goldenrod}{ █████████████████████▋ }}}$ 86.8%, 245.15 KB

Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js

Path Size
dist/exports/client ${{\color{Goldenrod}{ █████████████████████████ }}}$ 100.0%, 26.63 KB

Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js

Path Size
dist/graphics/Logo ${{\color{Goldenrod}{ ███████▋ }}}$ 30.5%, 5.57 KB
../../node_modules ${{\color{Goldenrod}{ ███▌ }}}$ 14.5%, 2.65 KB
dist/graphics/Icon ${{\color{Goldenrod}{ ██ }}}$ 8.3%, 1.51 KB
dist/utilities/formatDocTitle ${{\color{Goldenrod}{ █▊ }}}$ 7.2%, 1.32 KB
dist/providers/TableColumns ${{\color{Goldenrod}{ █▏ }}}$ 4.7%, 866 B
dist/utilities/getGlobalData.js ${{\color{Goldenrod}{ █ }}}$ 4.2%, 762 B
dist/utilities/api.js ${{\color{Goldenrod}{ █ }}}$ 4.1%, 756 B
dist/utilities/groupNavItems.js ${{\color{Goldenrod}{ █ }}}$ 4.1%, 745 B
dist/elements/Translation ${{\color{Goldenrod}{ ▋ }}}$ 2.7%, 493 B
dist/utilities/handleTakeOver.js ${{\color{Goldenrod}{ ▌ }}}$ 2.4%, 440 B
dist/utilities/traverseForLocalizedFields.js ${{\color{Goldenrod}{ ▌ }}}$ 2.3%, 419 B
dist/elements/withMergedProps ${{\color{Goldenrod}{ ▍ }}}$ 1.9%, 339 B
dist/utilities/getNavGroups.js ${{\color{Goldenrod}{ ▍ }}}$ 1.9%, 338 B
dist/utilities/getVisibleEntities.js ${{\color{Goldenrod}{ ▍ }}}$ 1.8%, 329 B
dist/elements/WithServerSideProps ${{\color{Goldenrod}{ ▎ }}}$ 1.3%, 232 B
dist/layouts/Root ${{\color{Goldenrod}{ ▎ }}}$ 1.3%, 230 B
dist/utilities/handleGoBack.js ${{\color{Goldenrod}{ ▎ }}}$ 1.0%, 180 B
dist/fields/mergeFieldStyles.js ${{\color{Goldenrod}{ ▏ }}}$ 0.9%, 158 B
dist/forms/Form ${{\color{Goldenrod}{ ▏ }}}$ 0.8%, 152 B
dist/utilities/handleBackToDashboard.js ${{\color{Goldenrod}{ ▏ }}}$ 0.8%, 152 B
(other) ${{\color{Goldenrod}{ █████████████████▍ }}}$ 69.5%, 12.68 KB
Details

Next to the size is how much the size has increased or decreased compared with the base branch of this PR.

  • ‼️: Size increased by 20% or more. Special attention should be given to this.
  • ⚠️: Size increased in acceptable range (lower than 20%).
  • ✅: No change or even downsized.
  • 🗑️: The out file is deleted: not found in base branch.
  • 🆕: The out file is newly found: will be added to base branch.

@denolfe
denolfe marked this pull request as ready for review July 17, 2026 19:56
@denolfe
denolfe requested a review from AlessioGr as a code owner July 17, 2026 19:56
@denolfe

denolfe commented Jul 17, 2026

Copy link
Copy Markdown
Member Author

✅ Successfully published a pre-release off of this branch

@denolfe
denolfe merged commit 517f4d1 into main Jul 20, 2026
508 of 513 checks passed
@denolfe
denolfe deleted the ci/rework-phase-1 branch July 20, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulpopus paulpopus paulpopus approved these changes
@AlessioGr AlessioGr Awaiting requested review from AlessioGr AlessioGr is a code owner

Assignees

No one assigned

Labels

created-by: Payload team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@denolfe @paulpopus