Skip to content

Add program to calculate factorial in Python#53

Open
Mahir-G wants to merge 1 commit into
pclubuiet:masterfrom
Mahir-G:master
Open

Add program to calculate factorial in Python#53
Mahir-G wants to merge 1 commit into
pclubuiet:masterfrom
Mahir-G:master

Conversation

@Mahir-G

@Mahir-G Mahir-G commented Oct 11, 2018

Copy link
Copy Markdown
Contributor

Resolve issue #41

@sagar-kalra sagar-kalra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the significance of 2nd commit?

Comment thread programs/factorial.py Outdated
else:
for i in range(1,num + 1):
factorial = factorial*i
print("The factorial of",num,"is",factorial)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space after ","

Comment thread programs/factorial.py Outdated
# Python program to find the factorial of a number provided by the user.

# change the value for a different result
num = 7

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove hard coded num

@Mahir-G

Mahir-G commented Oct 14, 2018

Copy link
Copy Markdown
Contributor Author

kindly review it now.

@divyam3897 divyam3897 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Program is to be added in language folder not programs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants