Update Mexico and Colombia KYC and KYB Forms#1131
Update Mexico and Colombia KYC and KYB Forms#1131Sharqiewicz wants to merge 13 commits intostagingfrom
Conversation
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Updates Alfredpay KYC UX/validation for Mexico and Colombia, and flips MXN/COP to “enabled” in the shared supported-fiat list (which affects both frontend availability and API quote validation).
Changes:
- Enabled MXN and COP in
SUPPORTED_FIAT_CURRENCIES. - Simplified Mexico KYC form by removing the document type field.
- Updated Colombia KYC form: stricter DNI/phone validation, switched document type input to the shared
Select, and adjusted phone input UI/normalization.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/shared/src/services/alfredpay/types.ts | Minor KYC request typing/comment tweak (no behavioral change). |
| packages/shared/src/endpoints/supported-fiat-currencies.endpoints.ts | Enables MXN/COP for shared “supported fiat” gating. |
| apps/frontend/src/components/Alfredpay/MxnKycFormScreen.tsx | Removes MX document type selection from the form. |
| apps/frontend/src/components/Alfredpay/ColKycFormScreen.tsx | Updates CO KYC validation and inputs (Select + phone input changes). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import type { MxnKycFormData } from "../../machines/alfredpayKyc.machine"; | ||
| import { MenuButtons } from "../MenuButtons"; |
| placeholder="573000000000" | ||
| type="tel" | ||
| {...register("phoneNumber", { | ||
| setValueAs: (v: string) => (v ? `+${v.replace(/^\+/, "")}` : v) |
|
@copilot apply changes based on the comments in this thread |
|
@copilot apply changes based on the comments in #1131 (review) |
…ization Agent-Logs-Url: https://github.com/pendulum-chain/vortex/sessions/b3c8ee52-8e6f-4d2a-9417-4c40ef144510 Co-authored-by: ebma <6690623+ebma@users.noreply.github.com>
Done in d4a0f65:
|
…ndulum-chain/vortex into feat/alfredpay-isExternal-us-checking
Sharqiewicz
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
apps/frontend/_redirects:21
- In Netlify redirects, the catch-all
/* /404.html 404rule comes before the non-www → www canonical redirect. Because redirect rules are evaluated top-to-bottom, requests tohttps://vortexfinance.co/...may match the catch-all first and return a 404 instead of redirecting. Move thehttps://vortexfinance.co/* https://www.vortexfinance.co/:splat 301!rule above the catch-all 404 (or add a more specific condition) so canonicalization still occurs.
# Everything else is a real 404
/* /404.html 404
https://vortexfinance.co/* https://www.vortexfinance.co/:splat 301!
| const alfredpayService = AlfredpayApiService.getInstance(); | ||
| const details = await alfredpayService.getKybBusinessDetails(alfredPayCustomer.alfredPayId); | ||
|
|
||
| res.json(details); | ||
| } catch (error) { |
| ), | ||
|
|
||
| submitKybBusinessFiles: fromPromise( | ||
| submitKybBusinessKyFiles: fromPromise( |
| state: z.string().min(1), | ||
| taxId: z.string().min(1), | ||
| website: z.string().url("Enter a valid URL").optional().or(z.literal("")), | ||
| website: z.string().url("Enter a valid URL"), | ||
| zipCode: z.string().min(1) |
No description provided.