fsl_imx: Drop extension allowing to boot ancient i.MX CPUs via UART - #61
fsl_imx: Drop extension allowing to boot ancient i.MX CPUs via UART#61ukleinek wants to merge 1 commit into
Conversation
The oldest i.MX CPU that I know is still in active use is i.MX25 launched in 2009. That one already uses USB for recovery booting. I think UART booting is only usable for the older i.MX1. So I guess removing this code doesn't hurt anyone. Compiling the source results in several warnings à la: commands_fsl_imx.c: In function ‘fsl_sniff’: commands_fsl_imx.c:597:17: warning: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 597 | read(ios->fd, &cmd, 1); | ^~~~~~~~~~~~~~~~~~~~~~ which are fixed by removing this code 😎. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
|
@ukleinek I wanted to give it some time for objections and would like to apply now. |
|
On the longer run I wish we'd have some mechanism to ensure a breaking change like this makes it into the changelog. For now I guess I can just try to remember it when creating the next release. |
|
My preferred approach here (and the one usually taken for the kernel) is to merge and let the merger resolve the conflicts (which here is just |
|
Ok, we can do it this way. |
fsl_imx: Drop extension allowing to boot ancient i.MX CPUs via UART
|
Applied manually in 0e63086 |
|
I realize I merged a rebased version now. This was unintentional |
The oldest i.MX CPU that I know is still in active use is i.MX25 launched in 2009. That one already uses USB for recovery booting. I think UART booting is only usable for the older i.MX1.
So I guess removing this code doesn't hurt anyone.
Compiling the source results in several warnings à la:
which are fixed by removing this code 😎.