Skip to content

Migrated linter fix - (Built on django-migrate and NOT main) - #312

Open
benjmnxu wants to merge 10 commits into
masterfrom
migrated-linter-fix
Open

Migrated linter fix - (Built on django-migrate and NOT main)#312
benjmnxu wants to merge 10 commits into
masterfrom
migrated-linter-fix

Conversation

@benjmnxu

@benjmnxu benjmnxu commented Apr 14, 2024

Copy link
Copy Markdown
Contributor

Restore backend checks for ohq deployment.

  • Black
  • Flake
  • No Ruff (idk what this is)
  • Backend test cases (which we haven't run in like two years lmao)
  • No Codecoverage. Uses an outdated django.yaml (We need to add codecoverage token into our secrets)

@benjmnxu
benjmnxu changed the base branch from master to django-migrate April 14, 2024 19:44
@benjmnxu benjmnxu changed the title Migrated linter fix - (Built on Migrated Branch and NOT main) Migrated linter fix - (Built on django-migrate and NOT main) Apr 14, 2024

@judtinzhang judtinzhang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Can you please take a look at penn-mobile's configs and see if playing with those helps anything (ex. codecov)? Let me know the results!

Comment thread .github/workflows/shared-build-deploy.yaml
Comment thread .github/workflows/shared-build-deploy.yaml
@benjmnxu

Copy link
Copy Markdown
Contributor Author

Main issue with codecov is just the token I believe. Error message on running codecov:

'Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.'

If the upload token is shared I'll keep looking into it. If it's ohq specific, I'll need to ask Bach or Dan to add it into our secrets

@judtinzhang

Copy link
Copy Markdown
Member

Makes sense, lmk if you stumble into anything else

@codecov

codecov Bot commented Apr 21, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.93%. Comparing base (cdc1334) to head (d4af60b).
⚠️ Report is 128 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   99.01%   98.93%   -0.08%     
==========================================
  Files          25       25              
  Lines        1316     1316              
==========================================
- Hits         1303     1302       -1     
- Misses         13       14       +1     
Flag Coverage Δ
backend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benjmnxu

benjmnxu commented Apr 21, 2024

Copy link
Copy Markdown
Contributor Author

Codecov token added. All tests pass.

@judtinzhang
judtinzhang self-requested a review April 21, 2024 18:39
Base automatically changed from django-migrate to master September 13, 2024 22:12
@anli5005
anli5005 force-pushed the migrated-linter-fix branch from 56e85d0 to d4af60b Compare June 6, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants