Skip to content
This repository was archived by the owner on Nov 9, 2022. It is now read-only.

PMM-10385 Explain tab.#186

Draft
JiriCtvrtka wants to merge 32 commits into
mainfrom
PMM-10385-disable-examples
Draft

PMM-10385 Explain tab.#186
JiriCtvrtka wants to merge 32 commits into
mainfrom
PMM-10385-disable-examples

Conversation

@JiriCtvrtka

@JiriCtvrtka JiriCtvrtka commented Oct 18, 2022

Copy link
Copy Markdown
Contributor

PMM-10385

Build: SUBMODULES-2835

Comment thread models/metrics.go Outdated
Comment thread models/metrics_test.go Outdated
Comment thread models/metrics_test.go Outdated
Comment thread models/metrics.go Outdated
@percona percona deleted a comment from github-actions Bot Nov 3, 2022
@percona percona deleted a comment from github-actions Bot Nov 3, 2022
@percona percona deleted a comment from github-actions Bot Nov 3, 2022
@percona percona deleted a comment from github-actions Bot Nov 3, 2022
Comment thread models/metrics.go
var queryBuffer bytes.Buffer
queryBuffer.WriteString(queryByQueryIDTmpl)

res := &qanpb.ExplainFingerprintByQueryIDReply{}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci-lint] reported by reviewdog 🐶
ExplainFingerprint, PlaceholdersCount are missing in ExplainFingerprintByQueryIDReply (exhaustivestruct)

This reverts commit 9bb4907.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant