Bound sitemap preload traversal#131
Merged
mehul0810 merged 1 commit intoJun 17, 2026
Merged
Conversation
|
Test on Playground |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #104.
Bound page-cache sitemap preload traversal so one seed run stops after a limited number of child sitemap fetches and after the existing URL cap is filled, instead of fetching every child sitemap first and trimming later.
Base Branch Evidence
1.7.0.release/1.7.0exists on origin.origin/release/1.7.0is the active release line for this milestone and is already ahead ofdevelopwith release-scoped cache work merged in PR Harden CDN rewrite load gating #129, so this fix branches from and targetsrelease/1.7.0.Scope
PageCache::fetch_urls_from_sitemap().Intentionally Excluded
Validation
php -l src/Modules/Cache/PageCache.phpphp -l tests/bootstrap.phpphp -l tests/unit-tests/tests-page-cache.php./vendor/bin/phpunit --filter Tests_Page_Cachecomposer testcomposer lint./vendor/bin/phpstan analyse --memory-limit=2048M --debugCompatibility, Security, Privacy
Rollback and Release Notes
Docs Status
AGENTS.mdupdate needed for this code-only runtime fix.Remaining Risk
@mehul0810 for release-line visibility.