Remove npm install from query scripts — deps managed by start-server.sh#193
Merged
Conversation
The CDM server startup (start-server.sh) already installs npm dependencies with a stamp-file guard. Running npm install redundantly in every query script (add-run, delete-run, get-metric-data, get-primary-periods, get-result-summary) is unnecessary and causes failures inside containers where overlay fs prevents npm from replacing directories (ENOTEMPTY on rmdir). Replace with a simple check that node_modules exists, with a clear error message pointing to start-server.sh if it doesn't. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
k-rister
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm installfrom 5 query wrapper scripts (add-run.sh, delete-run.sh, get-metric-data.sh, get-primary-periods.sh, get-result-summary.sh)start-server.shwhich runs at CDM server startup with a stamp-file guardnpm installinside containers with overlay fs causesENOTEMPTYfailures when npm tries tormdirdirectories from lower layersnode_modulesexistence check and clear error messageContext
Discovered via agentic-perf automated runs (PERF-7140E67D, PERF-D095E672): fio benchmarks complete successfully but OpenSearch indexing fails because
npm installinside the crucible controller container hits overlay fs issues (ENOTEMPTY: directory not empty, rmdir 'node_modules/js-yaml/lib'). This is a follow-up to PR #192 which added error reporting — this PR eliminates the root cause.Test plan
crucible runwith a benchmark — verify add-run.sh succeeds (node_modules present from start-server.sh)start-server.shstill installs deps on first launch🤖 Generated with Claude Code