fix: distribute shard tests round-robin to avoid PCRE backtrack limit#1744
Open
NarimanGardi wants to merge 1 commit into
Open
fix: distribute shard tests round-robin to avoid PCRE backtrack limit#1744NarimanGardi wants to merge 1 commit into
NarimanGardi wants to merge 1 commit into
Conversation
The no-cache --shard fallback chunked tests contiguously. Because --list-tests returns classes sorted, a chunk clustered classes sharing long common prefixes; joined into one unanchored --filter alternation it trips PCRE's backtrack limit on large suites, so the shard matched nothing and exited "No tests found". Interleave round-robin like the timings path already does for new tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1722.
When sharding without a
tests/.pest/shards.jsontimings file, the fallback split tests into contiguous chunks. Since--list-testsreturns classes sorted, a chunk is a cluster of classes sharing long common prefixes; joined into one unanchored--filteralternation it trips PCRE's backtrack limit on large suites —preg_matchreturnsfalse(PREG_INTERNAL_ERROR), so the shard matches nothing and exits "No tests found".This interleaves the fallback round-robin — the same approach the timings path already uses for new tests — so prefixes are scattered across shards and each shard's filter stays within PCRE limits. Extracted the distribution into
Shard::distribute()with unit tests.