Skip to content

feat: install agent-ci for local GitHub Actions validation (issue #20)#21

Draft
peterp wants to merge 13 commits into
masterfrom
kindling/2026-04-16-1242-work-on-issue-20-ca90
Draft

feat: install agent-ci for local GitHub Actions validation (issue #20)#21
peterp wants to merge 13 commits into
masterfrom
kindling/2026-04-16-1242-work-on-issue-20-ca90

Conversation

@peterp
Copy link
Copy Markdown
Owner

@peterp peterp commented Apr 16, 2026

Problem

The project lacked a continuous integration skill for Claude agents, meaning there was no standardized, reusable way to run quality gates — such as type checks, linting, and tests — within an automated agent workflow. Without this capability, agents completing implementation work had no reliable mechanism to verify their changes before finalizing a pull request. This gap created risk of undetected regressions and inconsistent code quality across agent-driven contributions.

Solution

A new agent CI skill was introduced and registered, providing a well-defined interface for running the project's quality gate steps from within an agent session. The necessary package dependencies were added and locked to ensure the skill operates in a reproducible environment. Supporting configuration and ignore rules were updated to keep the repository tidy, and an active work log was created to track the progress of this change through the standard investigation-to-finalization workflow.

@peterp
Copy link
Copy Markdown
Owner Author

peterp commented Apr 16, 2026

kindlingtask complete

Phases (4/4)

  • 1. Investigation
  • 2. Implementation
  • 3. Review
  • 4. Finalization

Completion report

Status: Done

What happened

Issue 20 was resolved across two developer passes and two reviewer passes. The agent-ci tool was installed as a project development dependency, the agent skill was registered with symlinked integration for Claude Code, and agent instructions were added requiring local validation before declaring work complete.

A revise cycle was triggered when the Reviewer found that command examples in the skill definition were using a registry-fetching form instead of invoking the locally installed binary — a violation of the project's pnpm-only convention. The Developer corrected all three affected commands, and the Reviewer passed the revision. PR 21 is open and ready for review.

Decisions made

  • Provisional decision: end-to-end CI workflow validation was explicitly deferred — it depends on a deploy workflow being created under a separate issue and is not a blocker for the current changes.
  • The skill definition fix was targeted directly at the source file with no compensating layers added elsewhere.

Worth noting

  • The deferred acceptance criterion (full end-to-end workflow validation) will need revisiting once the deploy workflow from Issue 9 exists.
  • The lock file grew substantially because this was the first resolution of the agent-ci package in this project's dependency graph.

Last updated: 2026-04-16T11:29:45.067Z

@peterp peterp changed the title Work on Issue 20 Install agent-ci for local workflow validation Apr 16, 2026
kindling and others added 8 commits April 16, 2026 10:49
Installs @redwoodjs/agent-ci@^0.10.7 as a devDependency via pnpm.
Adds .gitignore to exclude node_modules/.
Runs `pnpm dlx skills add redwoodjs/agent-ci --skill agent-ci --yes`.
Creates .agents/skills/agent-ci/SKILL.md (universal skill definition),
.claude/skills/agent-ci symlink (Claude Code integration), and
skills-lock.json locking the skill at commit eb25909.
Instructs agents to run agent-ci before declaring work done.
References issue #9 for the future --workflow flag once the
GitHub Actions deploy workflow is in place.
The project mandates pnpm exclusively. Since @redwoodjs/agent-ci is
already installed as a devDependency, pnpm exec agent-ci uses the
locally installed binary and respects the locked version — correct
over npx (which would fetch from the registry) or pnpm dlx (same).
@peterp
Copy link
Copy Markdown
Owner Author

peterp commented Apr 16, 2026

Addressed review feedback:

❌ SKILL.md uses npx instead of pnpm — convention violation

All three npx @redwoodjs/agent-ci ... invocations in the skill file have been replaced with pnpm exec agent-ci .... pnpm exec is used (not pnpm dlx) because the package is already installed as a devDependency — pnpm exec resolves the binary from the local node_modules and respects the version locked in pnpm-lock.yaml. No npx or npm references remain in the file.

@peterp peterp changed the title Install agent-ci for local workflow validation feat: install agent-ci for local GitHub Actions validation (issue #20) Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant