Add icons and large size to TagField - #162
Merged
Merged
Conversation
- Add icon/iconPosition to TagItem (Lucide icon, START/END, default START) - Icon color inherits the tag's text color via currentColor - Add LARGE tag size (SMALL | STANDARD | LARGE, no MEDIUM per SAIL docs) - Add tagSizeMap/tagIconSizeMap to sailMaps.ts as single source of truth - Tighten padding by 2px on the icon-adjacent side for visual balance - Add TagField.test.tsx covering sizing, icons, and accessibility - Add LargeSize, WithIcons, IconSizes stories - Update TAILWIND-SAIL-MAPPING.md Tag Sizes section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161
Summary
icon/iconPosition(START|END, defaultSTART) toTagItem, using Lucide icons (matchesButtonWidget's pattern)currentColorLARGEtag size (SMALL | STANDARD | LARGE; noMEDIUM, per SAIL docs)buttonSizeMap'stext-xl, but vertical padding stays shallow so tags keep their pill shape instead of growing to button heighttagSizeMap/tagIconSizeMap/tagHorizontalPaddingMapinsrc/utils/sailMaps.ts, consistent with the shared-map convention already used for buttonsTesting
src/components/Tag/TagField.test.tsx— 29 tests covering visibility, rendering, sizing, icons (position, color inheritance, invalid icon name, size scaling), the new padding adjustment, and accessibility (list/listitem roles, aria-hidden icons, accessible name from visible text)LargeSize,WithIcons,IconSizespnpm run lint: 0 errors (pre-existing warnings elsewhere, unrelated)pnpm run build:lib: type-checks and builds cleanlyNotes
role="listitem"which overrides the anchor's implicitlinkrole. Not fixed here since it's out of scope — happy to file a follow-up issue if useful.