Skip to content

Rk 598 dep rules config - #720

Draft
Robert-Krajcik wants to merge 17 commits into
devfrom
rk-598-dep_rules_config
Draft

Rk 598 dep rules config#720
Robert-Krajcik wants to merge 17 commits into
devfrom
rk-598-dep_rules_config

Conversation

@Robert-Krajcik

Copy link
Copy Markdown
Contributor

Add dependency rules to the config file
closes issue #598

@Robert-Krajcik Robert-Krajcik self-assigned this Dec 6, 2023
@Robert-Krajcik
Robert-Krajcik marked this pull request as ready for review December 6, 2023 13:48
@codecov

codecov Bot commented Dec 6, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 20.28986% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.46%. Comparing base (4cfdbfb) to head (7639d29).
⚠️ Report is 497 commits behind head on dev.

Files with missing lines Patch % Lines
R/mod_uploadPackage.R 19.11% 55 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #720      +/-   ##
==========================================
- Coverage   79.27%   78.46%   -0.81%     
==========================================
  Files          33       33              
  Lines        5022     5090      +68     
==========================================
+ Hits         3981     3994      +13     
- Misses       1041     1096      +55     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AARON-CLARK AARON-CLARK left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Robert-Krajcik, this is a nice start, but you'll also have to plug in those new configurations to something on the backend for the changes to take effect. @Jeff-Thompson12 is the expert on this stuff, but start off by doing a search for get_db_config() to learn how you can extract the values from the config file and use them in the app's code. So, in the example below, you'll have to run get_db_config('dependencies') to get a list (or a nested list?) of the sub-values you've established here.

Also, you may want to start off by adding the functionality that actually performs the auto assessment of dependencies. This would include adding a checkbox on the upload pkgs tab.

@AARON-CLARK
AARON-CLARK marked this pull request as draft December 12, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants