Print the rows in x that do not appear in y in print.compare_ard() - #607
Open
malanbos wants to merge 1 commit into
Open
Print the rows in x that do not appear in y in print.compare_ard()#607malanbos wants to merge 1 commit into
malanbos wants to merge 1 commit into
Conversation
The branch reporting rows present in `x` but not in `y` built the data frame and discarded it, so the block was announced and never shown. The `rows_in_y_not_x` branch below it already printed. Adds snapshot tests for `print.compare_ard()`, which had no coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
print.compare_ard()where the rows present inxbut not inywere announced and then not printed. (Bug Report: print.compare_ard() does not print the rows in x that are not in y #605, @malanbos)The
rows_in_x_not_ybranch built the data frame and discarded it, so the block printed its header and nothing else; it now prints, matching therows_in_y_not_xbranch immediately below it.print.compare_ard()had no test coverage at all, which is how this survived, so this adds snapshot tests covering equal ARDs, rows missing fromy, and rows missing fromx.I have left
NEWS.mdalone — the bullet above is ready to copy in at merge time.Reference GitHub issue associated with pull request.
Closes #605
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()devtools::test_coverage()Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site(). Check the R console for errors, and review the rendered website.devtools::test_coverage()When the branch is ready to be merged:
NEWS.mdwith the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).