Fix The Boulder, Ready to Rumble

[mike-theDude]

Summary

Fixes the "where X is <object count>" earthbend misparse for The Boulder, Ready to Rumble.

parse_earthbend_count_expr only recognized the where X is <counter count>
shape. For an object-count X ("the number of creatures you control with power 4
or greater"), it fell through to the bare-X branch, which bound X to
QuantityRef::Variable{X} — resolving to 0 for a triggered ability — and
mis-read the leftover "where X is…" text as an explicit target, degrading it to
TargetFilter::Any. The trigger fired but resolved to nothing.

The where-clause handler is generalized to route any "where X is
<dynamic quantity>" through the shared building blocks parse_quantity_ref
(object counts incl. P/T restrictions, subtype counts, player-counter counts)
then parse_event_context_quantity (mana spent to cast). A matched where-clause
now always resolves to default_earthbend_target() ("target land you control"),
so no unsupported shape can re-degrade the target. Covers the whole class: The
Boulder, Rockalanche ("Forests you control"), and Toph, Greatest Earthbender
("the amount of mana spent to cast her").

Closes #4729

Files changed

• crates/engine/src/parser/oracle_effect/imperative.rs
• crates/engine/src/parser/oracle_tests.rs

CR references

• CR 701.66a — Earthbend
• CR 107.3 — an ability defines the value of X

Implementation method (required)

Method: /engine-implementer

Track

Developer

LLM

Model: claude-opus-4-8
Thinking: high

Tier: Frontier

Verification

• Required checks ran clean, or the exact CI-owned alternative is stated below.

• Gate A output below is for the current committed head.

• Final review-impl below is clean for the current committed head.

• Both anchors cite existing analogous code at the same seam.

• cargo fmt --all — clean

• parser combinator gate (Gate A + Gate G) — PASS

• parser lib tests — 8191 PASS

• cargo clippy -p engine --lib — clean

• earthbend tests — 15 pass, 5 new (object-count-with-power-restriction,
  subtype count, mana-spent, unrecognized-where-clause-keeps-default-target,
  end-to-end The Boulder synthesis: Animate→land target + PutCounter→ObjectCount count)

Gate A

Gate A PASS head=68cb1e61531c53f036fbad592dc048f7cae26a04 base=c0d7e0f3a5d65c22b475491f0556a2655777980f

Anchored on

• crates/engine/src/parser/oracle_effect/imperative.rs — sibling parse_earthbend_params already delegates a dynamic count to parse_quantity_ref; the new where-clause branch mirrors that building-block delegation
• crates/engine/src/parser/oracle_effect/mod.rs — try_parse_earthbend_clause threads the parsed (target, count) into Effect::Animate.target + Effect::PutCounter.count; the fix changes only what the count parser returns, reusing this wiring unchanged

Final review-impl

Final review-impl PASS head=68cb1e61531c53f036fbad592dc048f7cae26a04

Claimed parse impact

• The Boulder, Ready to Rumble
• Rockalanche
• Toph, Greatest Earthbender

Validation Failures

None.

CI Failures

None.

🤖 Generated with Claude Code

[gemini-code-assist]

Code Review

This pull request updates the MTG engine's parser for earthbend effects to properly handle general 'where X is ' clauses in accordance with CR 701.66a and CR 107.3. Instead of degrading the target to TargetFilter::Any and failing to parse complex quantities, the parser now routes the clause through shared quantity parsers (parse_quantity_ref and parse_event_context_quantity) and correctly preserves the default earthbend target ('target land you control'). Comprehensive unit and integration tests have been added to verify these changes. There are no review comments to assess, and no additional feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[github-actions]

Parse changes introduced by this PR · 6 card(s), 1 signature(s) (baseline: main b81c77f71e86)

6 card(s) · ability/Animate · field target: any target → you control land

Examples: Beifong's Bounty Hunters, Bumi's Feast Lecture, Rockalanche (+3 more)

1 card(s) had Oracle-text changes (errata/reprint) — excluded as non-parser.

[matthewevans]

Verdict: Changes requested

🔴 Blocker

• parse_earthbend_count_expr now accepts every Earthbend X, where X is … clause, but an unrecognized quantity is deliberately lowered to QuantityRef::Variable("X") (crates/engine/src/parser/oracle_effect/imperative.rs:561-572). In triggered abilities that variable has no announced spell-cost X and resolves to 0, so the card is reported as parsed/supported while applying the wrong number of counters. The new glorbs test codifies that silent fallback (imperative.rs:14999-15023). Keep the default land target, but preserve an Effect::Unimplemented/strict-failure marker when the where-body cannot be parsed, rather than accepting the full clause with a fake X value.

🟡 Non-blocking

• None.

✅ Clean

• No additional findings.

Recommendation: Please address the unsupported-where-clause fallback, then request re-review.

[mike-theDude]

Addressed the blocker in aaa3606d4.

What changed: parse_earthbend_count_expr no longer accepts an unparseable where X is … body with a fabricated Variable{X}. It now returns Option, and a present-but-unrecognized where-body yields None. try_parse_earthbend_clause turns that None into an honest Effect::unimplemented("where_x_binding", …) gap, so coverage counts the card as unsupported until the quantity is handled — no more well-typed lie where a triggered ability silently applies 0 counters.

Unchanged: recognized quantities (object counts incl. the power 4 or greater restriction, subtype counts, player-counter counts, mana-spent-to-cast) still bind their typed value against default_earthbend_target(); and the genuine bare Earthbend X spell-cost path still resolves to Variable{X} (that X is announced at cast time, so it's correct there).

Tests: the glorbs test now asserts the strict None failure instead of the silent fallback (imperative.rs), plus a new end-to-end assertion that Earthbend X, where X is <unrecognized> lowers to Effect::Unimplemented (oracle_tests.rs).

Verification on the new head: cargo fmt clean · parser combinator gate PASS · 8192 parser lib tests pass · cargo clippy -p engine --lib clean · 16 earthbend tests pass.

Ready for re-review.

[matthewevans]

Verdict: Changes requested

🔴 Blocker

• The new coverage is still parser/AST-only for The Boulder. Please add one runtime witness that parses the card's actual attack trigger, extracts the Earthbend PutCounter.count, and resolves it against a board with exactly two qualifying friendly creatures (power 4 and 6), one non-qualifying friendly creature (power 3), and an opponent's qualifying creature. Assert 2. This must fail for the prior unbound-X behavior (0), for a dropped power restriction (3), and for a dropped controller restriction (4). counters::resolve_add consumes this quantity through resolve_quantity_with_targets, so this protects the reported counter-resolution behavior rather than merely its AST shape.

🟡 Non-blocking

• Update the parse_earthbend_count_expr dispatch-order doc comment: it still says unknown shapes become Fixed { value: 0 }, but the implementation now returns None for an unrecognized present where X is … body and the caller emits Effect::Unimplemented.

✅ Clean

• The strict-failure change itself is correct: recognized bodies route through the shared quantity parsers, preserve the default target land you control, and no longer silently accept an unknown where X is … quantity as an unbound X.

Recommendation: Add the focused runtime witness and align the contract comment, then request re-review.