[typeck]: reject return-path overlapping mut borrow (PHX-borrow-5) - #155
Merged
Merged
Conversation
Treat mutable borrows formed in return operands as ephemeral (like call arguments) so overlap is checked without leaving stale active borrows after return. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
returnoperands as ephemeral (same snapshot/restore model as call arguments), so overlap is checked without leaving stale active borrows after the return statement.source/phx-compiler/tests/typeck.rsfor explicit return, trailing return, distinct-binding acceptance, and non-persisting return borrows.Test plan
just fmtcargo test -p phx-compiler typeckjust pre-commitMade with Cursor