feat(ui): business-friendly quick add flow with keyboard shortcut N (SPEC-002, Task 102b9a48) - #113
Conversation
…ortcut N (SPEC-002)
|
Warning Review limit reached
Next review available in: 26 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c5d3263303
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| priority: finalPriority, | ||
| status, | ||
| estimate: finalEstimate, | ||
| ownerType: assigneeType, |
There was a problem hiding this comment.
When authentication is enabled and the caller has the ordinary user role, every quick-add request includes ownerType: 'unassigned'; the POST handler treats the presence of any ownership field as an assignment operation, so canAssignTasks rejects the request with 403 even though an otherwise identical create without ownership fields is allowed. Omit ownerType when no assignee was chosen so non-manager users can use the new flow.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in b813fcd: unassigned quick-add no longer sends ownerType. Assignment fields are only included when the user picks a human or agent.
| if (e.key === 'Enter') { | ||
| e.preventDefault(); | ||
| handleCreate(e.shiftKey || e.metaKey || e.ctrlKey); |
There was a problem hiding this comment.
During a slow create request, the title input remains active and every Enter keydown calls handleCreate without checking isSubmitting. Pressing Enter twice or holding the key can therefore issue multiple POSTs and create duplicate tasks even though the footer buttons are disabled; ignore keyboard submission while a request is pending.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in b813fcd: handleCreate and Enter return immediately while isSubmitting is true, so repeat Enter cannot create duplicates.
| const estMatch = clean.match(/@(\d+(?:\.\d+)?)(?:pt|h)?/i); | ||
| if (estMatch) { | ||
| parsedEstimate = parseFloat(estMatch[1]); | ||
| clean = clean.replace(estMatch[0], ''); |
There was a problem hiding this comment.
Because the estimate pattern has no token boundary and its unit is optional, ordinary titles containing numeric package/version notation are silently rewritten: for example, Upgrade React@18 becomes title Upgrade React with estimate 18. Require whitespace/token boundaries around inline shortcuts so valid title text is not removed.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in b813fcd: !priority and @estimate now require token boundaries, so Upgrade React@18 stays a title.
| const task = await onSubmit({ | ||
| projectId, | ||
| title, |
There was a problem hiding this comment.
When viewing project A, the project selector permits creating in project B, but App forwards the request through the project-A-scoped useTasks.createTask, which unconditionally appends the returned task to its local list. The project-B task consequently appears on project A's board until a refetch; either switch/refetch the selected project or avoid appending creates outside the active project.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in b813fcd: creating in another project calls api.createTask directly and does not append that task to the current board list.
| if ((e.key === 'n' || e.key === 'N') && !e.metaKey && !e.ctrlKey && !e.altKey) { | ||
| e.preventDefault(); | ||
| setQuickAddOpen(true); |
There was a problem hiding this comment.
The implemented global shortcut listens for N, while the acceptance criterion in docs/plans/baton-ux-sprint-r13.md:114 and SPEC-002 both assign Quick Add to T. Keyboard users following the documented workflow therefore cannot open the drawer with the promised key; align the listener and displayed badges with T.
AGENTS.md reference: AGENTS.md:L8-L8
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in b813fcd: the global shortcut, header badge, and modal hint now use T as specified by SPEC-002 / the sprint plan.
| useEffect(() => { | ||
| if (isOpen) { | ||
| setProjectId(selectedProjectId || projects[0]?.id || ''); | ||
| setRawTitle(''); | ||
| setError(null); | ||
| setTimeout(() => inputRef.current?.focus(), 50); |
There was a problem hiding this comment.
Closing and reopening the modal resets only the title, project, and error; status, priority, estimate, assignee, and work type retain their previous values. After creating or abandoning a specialized task, a subsequent quick add can silently inherit values such as done, critical, or an agent assignee instead of starting from the advertised defaults.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in b813fcd: opening the modal resets title, description, status, priority, estimate, assignee, work type, and error.
| <input | ||
| ref={inputRef} | ||
| type="text" | ||
| value={rawTitle} | ||
| onChange={e => setRawTitle(e.target.value)} | ||
| onKeyDown={handleKeyDown} | ||
| placeholder="What needs to be done? (Use @5pt or !high for quick formatting)..." |
There was a problem hiding this comment.
The quick-add body goes directly from the title input to metadata controls, leaving no way to enter the optional description required by docs/plans/baton-ux-sprint-r13.md:115, even though the submit contract already accepts description. Users must create and reopen every task that needs context, so expose and forward a description field in this flow.
AGENTS.md reference: AGENTS.md:L8-L8
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in b813fcd: Quick Add now has an optional description field and forwards it on create.
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Use T to open, omit unassigned ownerType, block repeat Enter, keep inline shortcuts token-bounded, reset all fields, add description, and do not append cross-project creates onto the active board.
1 participant
Summary