gen_stub: fix namespaced types in union/intersection type list#21717
Open
GromNaN wants to merge 1 commit intophp:masterfrom
Open
gen_stub: fix namespaced types in union/intersection type list#21717GromNaN wants to merge 1 commit intophp:masterfrom
GromNaN wants to merge 1 commit intophp:masterfrom
Conversation
Member
Author
|
Should I add update |
Member
Yes, please do. Perhaps adjusting one of the existing functions is sufficient. |
Member
|
Also, two unrelated changes should go into two PRs. Particularly if one is a good and one is a feature. |
GromNaN
force-pushed
the
fix-gen-stub-union-intersection-types
branch
from
b7300b4 to
b8b7060
Compare
GromNaN
changed the title
GromNaN
force-pushed
the
fix-gen-stub-union-intersection-types
branch
from
b8b7060 to
9ca590d
Compare
GromNaN
changed the title
Member
Author
|
Thanks for the feedback. I extracted the |
…ntersection type list When generating a union or intersection type list with multiple class types, the variable holding each zend_string* was declared using toVarEscapedName() (backslashes replaced by underscores), but the subsequent ZEND_TYPE_INIT_CLASS() reference used toEscapedName() (backslashes escaped as \\), producing an invalid C identifier.
GromNaN
force-pushed
the
fix-gen-stub-union-intersection-types
branch
from
9ca590d to
d51401d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in
build/gen_stub.php: when generating a type list for union/intersection types, thezend_string*variable was declared withtoVarEscapedName()but referenced withtoEscapedName(), producing an invalid C identifier for namespaced class names.