ext/phar: refactor phar_split_fname() to return zend_string* rather than out params#21777
Merged
Girgias merged 2 commits intophp:masterfrom Apr 17, 2026
Merged
ext/phar: refactor phar_split_fname() to return zend_string* rather than out params#21777Girgias merged 2 commits intophp:masterfrom
Girgias merged 2 commits intophp:masterfrom
Conversation
Girgias
force-pushed
the
2026-04-phar-refactor-2
branch
from
a26127c to
3523fc1
Compare
iluuu1994
approved these changes
Apr 17, 2026
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Couldn't see any obvious mistakes.
| * This is used by phar_parse_url() | ||
| */ | ||
| zend_result phar_split_fname(const char *filename, size_t filename_len, char **arch, size_t *arch_len, zend_string **entry, int executable, int for_create) /* {{{ */ | ||
| zend_string* phar_split_fname_ex(const char *filename, size_t filename_len, zend_string **entry, int executable, int for_create, const char **error) /* {{{ */ |
Member
There was a problem hiding this comment.
Nit: zend_string* pointer-style is much less common in the codebase (7k without space, 106k with space according to ripgrep, including some false positives for multiplication). I don't particularly care about which style is used but switching now is probably not useful.
Member
Author
There was a problem hiding this comment.
Right, what we maybe want to try and do is start with per extension clang format configurations and try to figure out what the usual CS is for each of them and slowly harmonise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.