Recognize simple current-class objects for unused private method#1069
Draft
kylekatarnls wants to merge 8 commits into3.xfrom
Draft
Recognize simple current-class objects for unused private method#1069kylekatarnls wants to merge 8 commits into3.xfrom
kylekatarnls wants to merge 8 commits into3.xfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x #1069 +/- ##
============================================
- Coverage 88.24% 87.66% -0.58%
- Complexity 1372 1429 +57
============================================
Files 112 116 +4
Lines 3581 3705 +124
============================================
+ Hits 3160 3248 +88
- Misses 421 457 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kylekatarnls
force-pushed
the
feature/detect-self-type-for-unused-private-method
branch
4 times, most recently
from
4ce69a6 to
f02541c
Compare
kylekatarnls
force-pushed
the
feature/detect-self-type-for-unused-private-method
branch
3 times, most recently
from
6ca471f to
8354e05
Compare
AJenbo
force-pushed
the
feature/detect-self-type-for-unused-private-method
branch
from
8354e05 to
26ef0d8
Compare
…ns, fix PHPStan errors
AJenbo
force-pushed
the
feature/detect-self-type-for-unused-private-method
branch
from
26ef0d8 to
56674a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bugfix
Issue: Resolves #252 / Resolves #558 / Resolves #937
Breaking change: no
Recognize simple constructions of the current class for unused private method rule, such as:
new Foo(with Foo matching FQCN of the current class, includingself,static)clone $this(or clone of a variable recognized as of type of the current class)