-
-
Notifications
You must be signed in to change notification settings - Fork 10
perf(test): explicit GC between suites — peak heap 1.87→1.64 GB (−12%) #3545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+39
−3
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /** | ||
| * Jest reporter that calls global.gc() after each test suite when available. | ||
| * | ||
| * Registered in jest.config.js reporters array alongside the default reporter. | ||
| * Requires --expose-gc in NODE_OPTIONS (already set in test:coverage script). | ||
| * | ||
| * Why: jest --runInBand accumulates module registry snapshots, mock closures, and | ||
| * Mongoose schema objects across 99 suites in a single process. V8's heuristic GC | ||
| * trigger is based on heap growth rate; calling gc() explicitly after each suite | ||
| * ensures the old generation is collected before the next suite loads its modules. | ||
| * This reduces peak RSS by releasing memory that V8 would otherwise hold until | ||
| * it reached the old-space limit. | ||
| * | ||
| * When --expose-gc is absent (test:all, test:unit, test:integration), global.gc | ||
| * is undefined and this reporter is a no-op, so it is safe to leave enabled for | ||
| * all test runs. | ||
| */ | ||
|
|
||
| class GcReporter { | ||
| /** | ||
| * Called by Jest after each test file completes. | ||
| * Triggers an explicit GC cycle when --expose-gc is active (test:coverage only). | ||
| * @param {object} _test - Jest test descriptor (unused). | ||
| * @param {object} _testResult - Aggregated results for this file (unused). | ||
| * @returns {void} | ||
| */ | ||
| onTestFileResult() { | ||
| if (typeof global.gc === 'function') { | ||
| global.gc(); | ||
| } | ||
| } | ||
|
PierreBrisorgueil marked this conversation as resolved.
|
||
| } | ||
|
|
||
| module.exports = GcReporter; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.