Skip to content

security: fix path-injection, SSRF & rate-limiting in namespace-notes (PIN-26) #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhamon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

security: fix path-injection, SSRF & rate-limiting in namespace-notes (PIN-26) #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions namespace-notes/client/src/app/api/files/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,20 @@ export interface FetchedFile {

export const maxDuration = 600

/**
* Validates a user-supplied identifier before it is used to build an outbound
* request URL. Only allows a conservative id charset and rejects anything that
* could alter the request path/host (slashes, dots, encoded traversal), then
* URL-encodes the value. This prevents server-side request forgery via the
* `namespaceId` / `documentId` query parameters.
*/
function safeId(value: string, label: string): string {
if (!/^[A-Za-z0-9_-]+$/.test(value)) {
throw new Error(`Invalid ${label}`);
}
return encodeURIComponent(value);
}

/**
* Fetches all file URLs for a given namespace from the backend server.
*
Expand All @@ -26,7 +40,10 @@ export async function GET(request: Request) {

try {
// Ensure the SERVER_URL is correctly configured in your environment
const url = `${process.env.SERVER_URL}/api/documents/files/${namespaceId}`;
const url = `${process.env.SERVER_URL}/api/documents/files/${safeId(
namespaceId,
"namespaceId"
)}`;
const response = await fetch(url, { method: "GET" });
const data = await response.json();

Expand Down Expand Up @@ -107,13 +124,17 @@ export async function DELETE(request: Request) {
let url;
let message;

const safeNamespaceId = safeId(namespaceId, "namespaceId");
if (typeof documentId === "string") {
// Delete a specific document
url = `${process.env.SERVER_URL}/api/documents/files/delete/${namespaceId}/${documentId}`;
url = `${process.env.SERVER_URL}/api/documents/files/delete/${safeNamespaceId}/${safeId(
documentId,
"documentId"
)}`;
message = "File deleted successfully";
} else {
// Delete the entire workspace/namespace
url = `${process.env.SERVER_URL}/api/documents/workspace/${namespaceId}`;
url = `${process.env.SERVER_URL}/api/documents/workspace/${safeNamespaceId}`;
message = "Workspace deleted successfully";
}

Expand Down
Loading