Reject git option injection in server mode - #57
Open
Hashim1999164 wants to merge 1 commit into
Open
Conversation
HTTP range and branch params were passed straight into git argv, so a value like --output=path could overwrite files. Reject revision args that start with '-', and bind the server to loopback only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #55.
HTTP
rangeandbranchvalues were passed as raw git argv entries. A value that begins with a dash (for example an output path flag) could make git write to an attacker chosen path. Revision style arguments that begin with a dash are now rejected, and the HTTP server listens on 127.0.0.1 only.Test plan
validate_git_revision_arggit_stacktrace.tests.test_gitandgit_stacktrace.tests.test_server