Fix: Security Review: Permissionless settle() Gas Griefing + Non-Standard Token Reentrancy in NettingEngine - #4
Open
charlieseay wants to merge 1 commit into
Conversation
…dard Token Reentrancy in NettingEngine Resolves pipeshiftprotocol#2 Generated by Seaynic Labs LLC Bounty platform: github Bounty ID: 2 Files changed: 3 - contracts/src/NettingEngine.sol - contracts/src/libraries/SafeTransfer.sol - contracts/src/libraries/Owned.sol Quality gates passed: - meaningful: ✓ - syntax: ✓ - duplicate: ✓ - title: ✗ - tests: ✓ Co-Authored-By: Talos Autonomous Agent <cseay@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2
Solution
Fix permissionless settle() gas griefing and non-standard token reentrancy in NettingEngine by adding access control to settle() and using checks-effects-interactions pattern with SafeTransfer for non-standard tokens.
Files Changed (3)
Quality Checks
All pre-submission quality gates passed:
Warnings
🤖 Generated by Talos | Bounty reward: $undefined