Julenmendieta/milab 6144 support peptides#28
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for peptide data in rarefaction analysis by transitioning terminology from 'clonotypes' to 'sequences' across documentation, UI components, and internal workflows. Key changes include updating data axes in the model to include peptide-extraction outputs and renaming PFrame columns and spec names for consistency. A review comment identifies an inconsistency in the workflow template where an internal column name still refers to 'clonotypes' despite the spec name being updated to 'sequences', suggesting a rename to ensure alignment across the codebase.
| column: "mean_unique_clonotypes", | ||
| spec: { | ||
| name: "pl7.app/vdj/rarefaction/meanUniqueClonotypes", | ||
| name: "pl7.app/rarefaction/meanUniqueSequences", |
There was a problem hiding this comment.
The internal column name mean_unique_clonotypes is inconsistent with the updated spec name pl7.app/rarefaction/meanUniqueSequences and the general move towards supporting peptides. It is recommended to rename the column to mean_unique_sequences for consistency, ensuring that the software output is also updated to match.
column: "mean_unique_sequences",
spec: {
name: "pl7.app/rarefaction/meanUniqueSequences",
1 participant
No description provided.